fix: raise manager memory limit to 4Gi (OOM at 2Gi)#139
Merged
Conversation
2Gi still OOMKilled the manager: the cluster-wide Secret informer cache (~33k secrets) spikes past 2Gi on cold-start LIST. Bump to 4Gi to cover the spike. Follow-up: scope the cache to user-argocd to stop scaling memory with total cluster secret count. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
- Coverage 49.16% 48.22% -0.94%
==========================================
Files 8 8
Lines 960 960
==========================================
- Hits 472 463 -9
- Misses 427 433 +6
- Partials 61 64 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2Gi still OOMKilled the manager. The controllers cache cluster-wide Secrets; with ~33,493 secrets in the cluster the cold-start LIST spikes past 2Gi. Bump to 4Gi.
Follow-up (separate): scope the informer cache with
cache.Options.ByObjecttouser-argocdso memory no longer scales with total cluster secret count.🤖 Generated with Claude Code