feat: defensive pre-flight checks — non-git, non-GitHub, default branch detection

Author: snese

code-review/SKILL.md

@@ -20,6 +20,15 @@ Invoke with: `code review`, `code-review`, `review`, or `review my code`
 3. **Structural issues > style issues** — ignore naming conventions; focus on logic, security, performance.
 4. **Severity levels** — Critical / High / Medium / Low so the user knows what to fix first.
 
+## Pre-flight
+
+1. **Detect context**: Are we in a git repo? Is there a diff to review?
+   - In git repo with uncommitted changes → review the uncommitted changes
+   - In git repo on feature branch → review diff against default branch
+   - User provided a file/snippet → review that directly
+   - Not in git repo, no file provided → ask user what to review
+2. **Detect language/framework** from file extensions and project files to tailor the checklist.
+
 ## Checklist
 
 ### Security
@@ -53,12 +62,13 @@ Invoke with: `code review`, `code-review`, `review`, or `review my code`
 
 ### 1. Get the Diff
 ```bash
-# If reviewing a branch
-git diff main...HEAD --stat
-git diff main...HEAD
+# In a git repo on feature branch
+git diff $(git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's@^refs/remotes/origin/@@' || echo main)...HEAD
+
+# Or uncommitted changes
+git diff
 
-# If reviewing a PR
-# Use GitHub API to get PR files
+# Or user-provided code — review directly
 ```
 
 ### 2. Review Each File
@@ -69,7 +79,7 @@ Scan every changed file against the checklist above.
 ## Output Format
 
 ```markdown
-# Code Review: {branch/PR}
+# Code Review: {branch/PR/file}
 
 ## Summary
 - Changes: {N} files, +{N} -{N} lines

qa/SKILL.md

@@ -20,11 +20,20 @@ Invoke with: `qa`, `test this`, `qa check`, or `run qa`
 3. **Severity levels** — Critical / High / Medium / Low with a health score
 4. **Actionable** — each issue includes steps to reproduce and suggested fix
 
+## Pre-flight
+
+1. **Detect context**:
+   - In git repo on feature branch → diff-aware mode (read `git diff` against default branch)
+   - In git repo, no changes → report "nothing to test"
+   - User provided a URL → URL testing mode
+   - Not in git repo → ask user what to test
+2. **Detect default branch**: `git symbolic-ref refs/remotes/origin/HEAD` or fall back to `main`
+
 ## Modes
 
 | Mode | Trigger | What it does |
 |------|---------|-------------|
-| Diff-aware | `qa` (on feature branch) | Read `git diff main`, test affected areas |
+| Diff-aware | `qa` (on feature branch) | Read diff against default branch, test affected areas |
 | URL | `qa https://...` | Test the given URL systematically |
 | Quick | `qa --quick` | 30-second smoke test: homepage + top 5 pages |
 | Full | `qa --full` | Exhaustive exploration, 5-15 minutes |
@@ -34,8 +43,9 @@ Invoke with: `qa`, `test this`, `qa check`, or `run qa`
 ### 1. Identify What to Test
 ```bash
 # On a feature branch: read the diff
-git diff main...HEAD --stat
-git diff main...HEAD
+DEFAULT=$(git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's@^refs/remotes/origin/@@' || echo main)
+git diff $DEFAULT...HEAD --stat
+git diff $DEFAULT...HEAD
 
 # Identify affected:
 # - Routes / endpoints

ship/SKILL.md

@@ -20,46 +20,66 @@ Invoke with: `ship`, `ship it`, or `ship this`
 3. **Stop on failure** — if any step fails, stop and report. Don't improvise fixes.
 4. **Speed** — minimum tool calls, fastest completion.
 
+## Pre-flight Checks
+
+Before starting, verify the environment:
+
+1. **Is this a git repo?** Run `git rev-parse --is-inside-work-tree`. If not → stop and report "Not a git repository."
+2. **Is there a remote?** Run `git remote -v`. If no remote → stop and report "No git remote configured."
+3. **Detect hosting platform** from remote URL:
+   - `github.com` → use GitHub API for PR
+   - `gitlab.com` → use GitLab API for MR
+   - Other → push only, skip PR creation, report "PR skipped: unsupported hosting platform"
+
 ## Workflow
 
 ### 1. Verify State
 ```bash
+# Confirm in a git repo
+git rev-parse --is-inside-work-tree || { echo "❌ Not a git repository."; exit 1; }
+
 # Confirm on a feature branch
 BRANCH=$(git branch --show-current)
-if [ "$BRANCH" = "main" ] || [ "$BRANCH" = "master" ]; then
-  echo "❌ You're on main. Can't ship. Switch to a feature branch first."
+DEFAULT=$(git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's@^refs/remotes/origin/@@' || echo "main")
+if [ "$BRANCH" = "$DEFAULT" ]; then
+  echo "❌ You're on $DEFAULT. Can't ship. Switch to a feature branch first."
   exit 1
 fi
 
 # Confirm no uncommitted changes
-git status --porcelain
+if [ -n "$(git status --porcelain)" ]; then
+  echo "❌ Uncommitted changes. Commit or stash first."
+  exit 1
+fi
 ```
 
-### 2. Sync Main
+### 2. Sync with default branch
 ```bash
 git fetch origin
-git rebase origin/main
+git rebase origin/$DEFAULT
 # If conflict → stop and report. Don't resolve automatically.
 ```
 
 ### 3. Run Tests (if the repo has them)
-```bash
-# Detect test framework and run
-# npm test / bun test / pytest / go test / cargo test / etc.
-# Failure → stop and report
-```
+Detect and run:
+- `package.json` with test script → `npm test` or `bun test`
+- `pytest.ini` / `pyproject.toml` / `setup.py` → `pytest`
+- `go.mod` → `go test ./...`
+- `Cargo.toml` → `cargo test`
+- `Makefile` with test target → `make test`
+- None found → skip, report "⏭️ no tests detected"
+
+Failure → stop and report.
 
 ### 4. Push
 ```bash
 git push origin HEAD
 ```
 
-### 5. Open PR
-Create a PR via GitHub API:
-- Title: concise summary of the changes
-- Body: auto-generated from commit messages
-- Labels: detect from context if possible
-- Base: `main`
+### 5. Open PR / MR
+- **GitHub**: create PR via API. Title from branch name or first commit. Body from commit log.
+- **GitLab**: create MR via API.
+- **Other**: skip, report push URL only.
 
 ### 6. Report
 
@@ -72,11 +92,13 @@ Create a PR via GitHub API:
 
 | Step | Status |
 |------|--------|
-| Branch check | ✅ `{branch}` |
-| Sync main | ✅ / ❌ conflict |
+| Git repo | ✅ / ❌ not a repo |
+| Branch check | ✅ `{branch}` / ❌ on default branch |
+| Clean state | ✅ / ❌ uncommitted changes |
+| Sync | ✅ / ❌ conflict |
 | Tests | ✅ / ⏭️ no tests / ❌ failed |
 | Push | ✅ |
-| PR | ✅ {PR URL} |
+| PR/MR | ✅ {URL} / ⏭️ unsupported platform |
 
 ## Commits ({N})
 - {commit 1}
@@ -92,3 +114,4 @@ Create a PR via GitHub API:
 - The entire flow should take no more than 10 tool calls
 - Don't add changelog/version bump unless the repo has that convention
 - PR opened = done. Don't wait for review.
+- If the platform is unsupported for PR, a successful push is still a successful ship.