Skip to content

feat: add --nodeclined support to remind command #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snomiao wants to merge 3 commits into from
Closed

feat: add --nodeclined support to remind command #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0916e1
feat: add flake and shell.nix
portothree Aug 31, 2022
b9c4e7b
chore: update shell.nix
portothree Aug 31, 2022
f0ba425
feat: accept nodeclined arg on gcal.Remind
portothree Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
description = "gcalcli";
inputs = { nixpkgs = { url = "nixpkgs/nixos-22.05"; }; };
outputs = { self, nixpkgs }:
let
system = "x86_64-linux";
pkgs = import nixpkgs { inherit system; };
in { devShells.${system}.default = import ./shell.nix { inherit pkgs; }; };
}
2 changes: 1 addition & 1 deletion gcalcli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def main():
elif parsed_args.command == 'remind':
gcal.Remind(
parsed_args.minutes, parsed_args.cmd,
use_reminders=parsed_args.use_reminders
parsed_args.nodeclined, use_reminders=parsed_args.use_reminders
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parsed_args.nodeclined attribute will not exist because the --nodeclined flag is not defined in the remind subcommand parser. This will cause an AttributeError at runtime. The --nodeclined flag needs to be added to the remind subcommand definition in argparsers.py (either directly or by including output_parser as a parent).

Copilot uses AI. Check for mistakes.
)

elif parsed_args.command == 'import':
Expand Down
2 changes: 1 addition & 1 deletion gcalcli/gcal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@ def ModifyEvents(self, work, search_text, start=None, end=None,
return self._iterate_events(
self.now, event_list, year_date=True, work=work)

def Remind(self, minutes, command, use_reminders=False):
def Remind(self, minutes, command, nodeclined, use_reminders=False):
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nodeclined parameter is accepted but never used in the Remind method implementation. Following the pattern used by other methods like _tsv (line 604) and _iterate_events (line 1014), this method should check if self.options['ignore_declined'] and self._DeclinedEvent(event): continue in the event loop starting at line 1386. Note that the parameter should not be passed explicitly since it's already available via self.options after being passed through **vars(parsed_args) to GoogleCalendarInterface.

Copilot uses AI. Check for mistakes.
"""
Check for events between now and now+minutes.

Expand Down
6 changes: 6 additions & 0 deletions shell.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{ pkgs ? import <nixpkgs> { } }:

let
python38WithPackages =
(pkgs.python38.withPackages (pythonPackages: with pythonPackages; [ tox ]));
in pkgs.mkShell { buildInputs = [ python38WithPackages ]; }