feat: add --nodeclined support to remind command#9
Merged
Conversation
…#636) Wire output_parser (which includes --nodeclined/ignore_declined) into the remind subparser and apply the existing _DeclinedEvent() filter pattern inside Remind() to skip declined events. The original PR only added a dead parameter; this implementation uses the existing self.options['ignore_declined'] pattern consistent with all other commands that respect --nodeclined. Co-Authored-By: Gustavo Porto <gustavo@portosanti.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the --nodeclined flag to the remind command, allowing users to filter out declined events from reminders. This is particularly useful for users on shared calendars who don't want to receive reminders for events they've declined.
Changes:
- Added
output_parseras a parent to theremindsubcommand definition in argparsers.py to make the--nodeclinedflag available - Implemented the declined event filtering logic in the
Remind()method using the establishedself.options['ignore_declined'] and self._DeclinedEvent(event)pattern
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gcalcli/argparsers.py | Added output_parser to the remind subcommand's parent parsers to expose the --nodeclined flag |
| gcalcli/gcal.py | Added declined event filtering logic in the Remind() method, consistent with other event-processing methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from insanum/gcalcli#636 by @portothree. Re-implemented cleanly from main (original branch was based on 2022 code, 9 commits behind).
Summary
output_parseras a parent to theremindsubcommand so--nodeclinedflag is availableRemind(), applies the existingself.options['ignore_declined'] and self._DeclinedEvent(event)pattern — consistent with agenda/search/etc.Why
Users on shared calendars with many declined events don't want reminders firing for events they've already declined.
Note
The original PR only added
nodeclinedas a dead parameter without using it. This implementation is complete and tested (63 tests pass).🤖 Generated with Claude Code