fix(cmd): resolve test state leakage and flakiness

Fix global variable modification in runDeactivate and TestRunLockCheck which caused unpredictable test failures in parallel or randomized testing environments (e.g. CI).

Author: snowdream

cmd/10.deactivate.go

@@ -65,16 +65,17 @@ func runDeactivate(cmd *cobra.Command, args []string) error {
 
 	// Detect shell if not specified
 	// Detect shell if not specified in flags
-	if deactivateShell == "" && len(args) > 0 {
+	shellToUse := deactivateShell
+	if shellToUse == "" && len(args) > 0 {
 		firstArg := strings.ToLower(args[0])
 		// Check if first arg is a known shell name
 		if firstArg == "bash" || firstArg == "zsh" || firstArg == "fish" || firstArg == "powershell" || firstArg == "pwsh" {
-			deactivateShell = firstArg
+			shellToUse = firstArg
 			args = args[1:] // Shift args
 		}
 	}
 
-	shellType, err := resolveShellType(deactivateShell)
+	shellType, err := resolveShellType(shellToUse)
 	if err != nil {
 		formatter.Error("Failed to detect shell", map[string]interface{}{
 			"error": err.Error(),

cmd/31.lock_test.go

@@ -18,6 +18,9 @@ func TestRunLockCheck(t *testing.T) {
 	t.Setenv("UNIRTM_DATA_DIR", tmpDir)
 	t.Setenv("UNIRTM_CONFIG_DIR", tmpDir)
 
+	// Reset global flags to prevent leakage from other tests
+	lockCheck = false
+
 	// Since there is no config file, it should just return no error
 	err := lockCmd.RunE(lockCmd, []string{})
 	assert.NoError(t, err)