test: mock USERPROFILE to prevent test pollution on Windows

In tests, mocking only HOME leaves Windows runners vulnerable to modifying actual host directories since os.UserHomeDir relies on USERPROFILE on Windows.

Author: snowdream

cmd/17.use_test.go

@@ -8,7 +8,6 @@ import (
 	"context"
 	"os"
 	"path/filepath"
-	"runtime"
 	"strings"
 	"testing"
 
@@ -103,9 +102,7 @@ func TestRunUse_Global(t *testing.T) {
 	// HOME is used by os.UserHomeDir() on Unix.
 	// On Windows, os.UserHomeDir() reads USERPROFILE (or HOMEDRIVE+HOMEPATH).
 	t.Setenv("HOME", tmpDir)
-	if runtime.GOOS == "windows" {
-		t.Setenv("USERPROFILE", tmpDir)
-	}
+	t.Setenv("USERPROFILE", tmpDir)
 
 	cmd := useCmd
 	cmd.SetContext(context.Background())

cmd/46.enable_test.go

@@ -22,6 +22,7 @@ func TestEnableCommandStructure(t *testing.T) {
 func TestRunEnable(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	// Create a dummy shell config
 	err := os.WriteFile(filepath.Join(tmpDir, ".zshrc"), []byte("# init\n"), 0644)
@@ -41,6 +42,7 @@ func TestRunEnable(t *testing.T) {
 func TestRunEnable_All(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	err := os.WriteFile(filepath.Join(tmpDir, ".zshrc"), []byte("# init\n"), 0644)
 	require.NoError(t, err)

cmd/47.disable_test.go

@@ -22,6 +22,7 @@ func TestDisableCommandStructure(t *testing.T) {
 func TestRunDisable(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	// Create a dummy shell config
 	err := os.WriteFile(filepath.Join(tmpDir, ".zshrc"), []byte("# init\n# unirtm config here\n"), 0644)
@@ -41,6 +42,7 @@ func TestRunDisable(t *testing.T) {
 func TestRunDisable_All(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	err := os.WriteFile(filepath.Join(tmpDir, ".zshrc"), []byte("# init\n# unirtm config here\n"), 0644)
 	require.NoError(t, err)

cmd/e2e_harness_test.go

@@ -62,6 +62,7 @@ func (h *E2EHarness) Run(args ...string) (stdout string, stderr string, err erro
 	h.t.Setenv("XDG_DATA_HOME", h.TmpDir)
 	h.t.Setenv("XDG_CONFIG_HOME", h.TmpDir)
 	h.t.Setenv("HOME", h.TmpDir)
+	h.t.Setenv("USERPROFILE", h.TmpDir)
 
 	// Intercept os.Stdout and os.Stderr
 	oldStdout := os.Stdout

internal/backend/github_token_test.go

@@ -385,7 +385,6 @@ func TestFindGhHostsFile_MacosFallback(t *testing.T) {
 	t.Setenv("GH_CONFIG_DIR", "")
 	t.Setenv("UNIRTM_XDG_CONFIG_HOME", "")
 	t.Setenv("MISE_XDG_CONFIG_HOME", "")
-	t.Setenv("XDG_CONFIG_HOME", "")
 	t.Setenv("HOME", homeDir)
 	t.Setenv("USERPROFILE", homeDir)
 

internal/config/loader_more_test.go

@@ -14,6 +14,7 @@ import (
 func TestLoader_LoadGlobal(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 	t.Setenv("XDG_CONFIG_HOME", tmpDir)
 
 	globalPath := GetGlobalConfigPath()

internal/config/trust_more_test.go

@@ -12,6 +12,7 @@ import (
 func TestTrustManager(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 	t.Setenv("XDG_CONFIG_HOME", tmpDir)
 
 	tm := NewTrustManager()

internal/pkg/env/env_more_test.go

@@ -78,6 +78,7 @@ func TestEnv_PathsFallback(t *testing.T) {
 	// keep HOME so os.UserHomeDir works, otherwise it might panic or error
 	homeDir, _ := os.UserHomeDir()
 	t.Setenv("HOME", homeDir)
+	t.Setenv("USERPROFILE", homeDir)
 
 	cfg := GetConfigDir()
 	assert.NotEmpty(t, cfg)