fix(install): skip atomic rename for Python providers to avoid PE executable corruption

On Windows, Python pip packages generate .exe wrappers that embed the absolute path of the virtual environment. UniRTM's atomic installation strategy (installing into .unirtm-tmp and renaming) caused these embedded paths to break, leading to silent exit code 1 failures (like with pre-commit). Added an opt-out mechanism for atomic rename for Python/Pypi providers.

Author: snowdream

internal/provider/pypi.go

@@ -28,6 +28,12 @@ func (p *PypiProvider) Name() string {
 	return "pypi"
 }
 
+// SkipAtomicRename indicates that this provider requires installing directly into the final path.
+// This is necessary because Python virtualenvs hardcode absolute paths in executable PE wrappers on Windows.
+func (p *PypiProvider) SkipAtomicRename() bool {
+	return true
+}
+
 func (p *PypiProvider) Install(ctx context.Context, tool string, installPath string, artifactPath string, version string) error {
 	// Ensure parent dir exists
 	if err := os.MkdirAll(filepath.Dir(installPath), 0755); err != nil {

internal/provider/python.go

@@ -30,6 +30,12 @@ func (p *PythonProvider) Name() string {
 	return "python"
 }
 
+// SkipAtomicRename indicates that this provider requires installing directly into the final path.
+// This is necessary because Python virtualenvs hardcode absolute paths in executable PE wrappers on Windows.
+func (p *PythonProvider) SkipAtomicRename() bool {
+	return true
+}
+
 // Install performs Python-specific installation.
 func (p *PythonProvider) Install(ctx context.Context, tool string, installPath string, artifactPath string, version string) error {
 	return p.generic.Install(ctx, tool, installPath, artifactPath, version)

internal/service/installation.go

@@ -673,38 +673,49 @@ func (im *InstallationManager) Install(ctx context.Context, toolKey, tool, versi
 	installPath := filepath.Join(env.GetInstallsDir(), fsToolName, version)
 	tmpInstallPath := installPath + ".unirtm-tmp"
 
+	p := im.providerRegistry.GetWithBackend(tool, backendName)
+
+	var actualInstallPath string
+	if skippable, ok := p.(interface{ SkipAtomicRename() bool }); ok && skippable.SkipAtomicRename() {
+		actualInstallPath = installPath
+	} else {
+		actualInstallPath = tmpInstallPath
+	}
+
 	// Clean up any stale directories from previous failed attempts
-	os.RemoveAll(tmpInstallPath)
-	// If final path exists but we reached here, it means it's not in the database.
-	// We'll overwrite it to be safe.
-	os.RemoveAll(installPath)
+	os.RemoveAll(actualInstallPath)
+	if actualInstallPath != installPath {
+		// If final path exists but we reached here, it means it's not in the database.
+		// We'll overwrite it to be safe.
+		os.RemoveAll(installPath)
+	}
 
-	if err := os.MkdirAll(filepath.Dir(tmpInstallPath), 0755); err != nil {
+	if err := os.MkdirAll(filepath.Dir(actualInstallPath), 0755); err != nil {
 		return fmt.Errorf("failed to create installs directory: %w", err)
 	}
 
-	p := im.providerRegistry.GetWithBackend(tool, backendName)
-
 	if !quietProgress {
 		fmt.Printf("ℹ extracting %s@%s...\n", tool, version)
 	}
-	if err := p.Install(ctx, tool, tmpInstallPath, downloadPath, version); err != nil {
-		os.RemoveAll(tmpInstallPath)
+	if err := p.Install(ctx, tool, actualInstallPath, downloadPath, version); err != nil {
+		os.RemoveAll(actualInstallPath)
 		return fmt.Errorf("installation failed: %w", err)
 	}
 
 	if !quietProgress {
 		fmt.Printf("ℹ running post-install hooks for %s@%s...\n", tool, version)
 	}
-	if err := p.PostInstall(ctx, tool, tmpInstallPath, version); err != nil {
-		os.RemoveAll(tmpInstallPath)
+	if err := p.PostInstall(ctx, tool, actualInstallPath, version); err != nil {
+		os.RemoveAll(actualInstallPath)
 		return fmt.Errorf("post-install failed: %w", err)
 	}
 
-	// Atomic rename from temp to final path
-	if err := os.Rename(tmpInstallPath, installPath); err != nil {
-		os.RemoveAll(tmpInstallPath)
-		return fmt.Errorf("failed to finalize installation: %w", err)
+	if actualInstallPath != installPath {
+		// Atomic rename from temp to final path
+		if err := os.Rename(actualInstallPath, installPath); err != nil {
+			os.RemoveAll(actualInstallPath)
+			return fmt.Errorf("failed to finalize installation: %w", err)
+		}
 	}
 
 	if !quietProgress {