Add live upload progress bar for DCM file sync#3068
Draft
sfc-gh-jsommerfeld wants to merge 3 commits into
Draft
Conversation
Introduce DeployProgressTracker (progress.py) with a live Rich display that shows the UPLOAD phase as files are synced to a temporary stage before any DCM operation (deploy, plan, analyze). - DeployProgressTracker renders a phase checklist; the UPLOAD row shows a braille spinner, a per-group file-count summary, and transitions to a green check when complete. - sync_local_files gains an optional `progress` parameter; when supplied it calls progress.set_upload_context / advance_upload / complete_upload so the UI updates in real time. - _summarize_upload_paths replaces _report_files_to_be_deployed: groups files by sources/ subfolder and pads "file " to align with "files". - styles.py adds PHASE_DONE / PHASE_RUNNING / PHASE_FAILED color tokens. Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-jsommerfeld
marked this pull request as draft
May 31, 2026 20:31
Make progress.py the single source of truth for the phase checklist so the deploy/plan/purge and compile/dependencies command lines can't diverge: - every operation uses the same RENDER -> COMPILE -> PLAN -> DEPLOY/PURGE vocabulary - the "compile" operation runs the server-side ANALYZE statement, but ANALYZE is an implementation detail and is never shown as a phase (it renders RENDER -> COMPILE and stops) - add the server-side "purge" operation (no UPLOAD; DEPLOY shown as PURGE) and per-operation display-name overrides Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 8, 2026
Collapse the two divergent blues — the periwinkle hex #a0a8fe (refresh status / unknown rows) and the terminal-default named "blue" (running phase, progress bar/spinner) — onto one BLUE constant in styles.py, and route progress.py's hardcoded style="blue" literals through it, so every blue in DCM output renders the same hue. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
DeployProgressTracker(progress.py) with a live Rich display that shows the UPLOAD phase as files are synced to a temporary stage before any DCM operation, and establishprogress.pyas the single source of truth for the phase checklist used by every DCM command.DeployProgressTrackerrenders a phase checklist; the UPLOAD row shows a braille spinner, a per-group file-count summary, and transitions to a green check when complete.sync_local_filesgains an optionalprogressparameter; when supplied it callsprogress.set_upload_context/advance_upload/complete_uploadso the UI updates in real time._summarize_upload_pathsreplaces_report_files_to_be_deployed: groups files bysources/subfolder and pads"file "to align with"files".styles.pyaddsPHASE_DONE/PHASE_RUNNING/PHASE_FAILEDcolor tokens.Canonical phase model
progress.pyowns_PHASES_BY_OPERATIONfor all operations so the deploy/plan/purge and compile/dependencies command lines can't diverge. Every operation uses the sameRENDER → COMPILE → PLAN → DEPLOY/PURGEvocabulary (the consuming commands are wired up in the PRs stacked on top of this one):deploy: UPLOAD → RENDER → COMPILE → PLAN → DEPLOYplan: UPLOAD → RENDER → COMPILE → PLANcompile: UPLOAD → RENDER → COMPILE (runs the server-side ANALYZE statement, but ANALYZE is an implementation detail and is never shown as a phase)purge: RENDER → COMPILE → PLAN → PURGE (no UPLOAD; the server-side DEPLOY phase is displayed asPURGEvia a per-operation display-name override)Pre-review checklist
RELEASE-NOTES.md(see when and how).Changes description
...