Skip to content

Commit 4c75b02

Browse files
add tests
1 parent cdc8f65 commit 4c75b02

2 files changed

Lines changed: 626 additions & 7 deletions

File tree

src/snowflake/snowpark/dataframe_reader.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -246,13 +246,6 @@ def _parse_structured_type_str(type_str, max_string_size):
246246
if not type_str:
247247
return VariantType()
248248

249-
# wufan TODO:
250-
# # Strip top-level NOT NULL before routing. INFER_SCHEMA may annotate
251-
# # any column type (e.g., "TEXT NOT NULL"). The nullable info is not
252-
# # used at this level since column nullability comes from INFER_SCHEMA's
253-
# # nullable field, not from the type string.
254-
# type_str, _ = extract_nullable_keyword(type_str)
255-
256249
result = _extract_paren_content(type_str)
257250
base_upper = result[0].upper() if result else type_str.upper()
258251

0 commit comments

Comments
 (0)