Skip to content

Commit 7fa1665

Browse files
committed
enable python 3.13 test
1 parent b652cae commit 7fa1665

1 file changed

Lines changed: 2 additions & 16 deletions

File tree

.github/workflows/precommit.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ jobs:
183183
# For example, see https://github.com/snowflakedb/snowpark-python/pull/681
184184
shell: bash
185185
# do not run other tests for macos
186-
- if: ${{ matrix.os != 'macos-latest' && matrix.python-version != '3.13' }}
186+
- if: ${{ matrix.os != 'macos-latest' }}
187187
name: Run tests (excluding doctests)
188188
run: python -m tox -e "py${PYTHON_VERSION/\./}-notdoctest-ci"
189189
env:
@@ -194,19 +194,6 @@ jobs:
194194
SNOWPARK_PYTHON_API_TEST_BUCKET_PATH: ${{ secrets.SNOWPARK_PYTHON_API_TEST_BUCKET_PATH }}
195195
SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION: ${{ vars.SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION }}
196196
shell: bash
197-
# SNOW-2213578 : Remove the test below and run udf tests for 3.13
198-
# for 3.13, skip udf, doctest
199-
- if: ${{ matrix.os != 'macos-latest' && matrix.python-version == '3.13' }}
200-
name: Run tests (excluding udf, doctests)
201-
run: python -m tox -e "py${PYTHON_VERSION/\./}-notudfdoctest-ci"
202-
env:
203-
PYTHON_VERSION: ${{ matrix.python-version }}
204-
cloud_provider: ${{ matrix.cloud-provider }}
205-
PYTEST_ADDOPTS: --color=yes --tb=short
206-
SNOWPARK_PYTHON_API_TEST_BUCKET_PATH: ${{ secrets.SNOWPARK_PYTHON_API_TEST_BUCKET_PATH }}
207-
SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION: ${{ vars.SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION }}
208-
TOX_PARALLEL_NO_SPINNER: 1
209-
shell: bash
210197
- name: Install MS ODBC Driver (Ubuntu only)
211198
if: ${{ contains(matrix.os, 'ubuntu') }}
212199
run: |
@@ -217,8 +204,7 @@ jobs:
217204
shell: bash
218205
- name: Run data source tests
219206
# psycopg2 is not supported on macos 3.9
220-
# SNOW-2213578: Re-enable the test for 3.13
221-
if: ${{ !(matrix.os == 'macos-latest' && matrix.python-version == '3.9') && !(matrix.python-version == '3.13') }}
207+
if: ${{ !(matrix.os == 'macos-latest' && matrix.python-version == '3.9') }}
222208
run: python -m tox -e datasource
223209
env:
224210
PYTHON_VERSION: ${{ matrix.python-version }}

0 commit comments

Comments
 (0)