Skip to content

SNOW-1757443: Implement GroupBy rolling #3686

Merged
sfc-gh-lmukhopadhyay merged 36 commits into
mainfrom
lmukhopadhyay-SNOW-1757443-groupby-rolling
Oct 22, 2025
Merged

SNOW-1757443: Implement GroupBy rolling #3686
sfc-gh-lmukhopadhyay merged 36 commits into
mainfrom
lmukhopadhyay-SNOW-1757443-groupby-rolling

Conversation

@sfc-gh-lmukhopadhyay

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay commented Aug 21, 2025

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1757443

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay marked this pull request as ready for review August 25, 2025 20:54
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested a review from a team as a code owner August 25, 2025 20:54
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested review from sfc-gh-jjiao and sfc-gh-mvashishtha and removed request for sfc-gh-jjiao August 25, 2025 20:54
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/docstrings/groupby.py Outdated
Comment thread docs/source/modin/supported/groupby_supported.rst
@sfc-gh-helmeleegy

Copy link
Copy Markdown
Contributor

Hi @sfc-gh-lmukhopadhyay, did you get a chance to take a look at the comments I left a while back?

@sfc-gh-helmeleegy

Copy link
Copy Markdown
Contributor

Hi @sfc-gh-lmukhopadhyay, did you get a chance to take a look at the comments I left a while back?

Actually, nvm. I just noticed that you are in the process of making code changes to address them already.

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the query compiler left to review

Comment thread src/snowflake/snowpark/modin/plugin/extensions/dataframe_groupby_overrides.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/docstrings/groupby.py Outdated

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got through line 5585 of the query compiler.

Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py
Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. LGTM after addressing Mahesh's remaining comments.

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took one pass through all the files

Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. I have a few more.

Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated
Comment thread src/snowflake/snowpark/modin/plugin/docstrings/groupby.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py Outdated
Comment thread tests/integ/modin/groupby/test_groupby_rolling.py Outdated
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Comment thread src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py Outdated
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 569aef4 into main Oct 22, 2025
29 of 30 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-1757443-groupby-rolling branch October 22, 2025 22:18
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants