Skip to content

SNOW-2296280: Add interval_day_time_from_parts function#3702

Merged
sfc-gh-yuwang merged 39 commits into
mainfrom
fhe-SNOW-2296280-add-make_dt_interval-function
Sep 16, 2025
Merged

SNOW-2296280: Add interval_day_time_from_parts function#3702
sfc-gh-yuwang merged 39 commits into
mainfrom
fhe-SNOW-2296280-add-make_dt_interval-function

Conversation

@sfc-gh-fhe

@sfc-gh-fhe sfc-gh-fhe commented Aug 25, 2025

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2272863-support-daytimeintervaltype branch from e0c60bd to 37b2c83 Compare August 26, 2025 18:08
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 8a40007 to 9bdb6c2 Compare August 26, 2025 22:10
Comment thread src/snowflake/snowpark/functions.py Outdated
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2272863-support-daytimeintervaltype branch from 37b2c83 to 9270018 Compare September 3, 2025 20:29
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 24f0ce4 to a86c040 Compare September 3, 2025 20:32
@sfc-gh-fhe sfc-gh-fhe changed the title SNOW-2296280: Add make_dt_interval function SNOW-2296280: Add interval_day_time_from_parts function Sep 3, 2025
Comment thread src/snowflake/snowpark/functions.py Outdated
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2272863-support-daytimeintervaltype branch 3 times, most recently from 439956e to 98f1d93 Compare September 4, 2025 00:26
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 0c8fed7 to 99dd28b Compare September 4, 2025 00:31
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2272863-support-daytimeintervaltype branch from e5f230d to e404b3f Compare September 4, 2025 01:08
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from f005805 to 50a41c7 Compare September 4, 2025 01:11
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2272863-support-daytimeintervaltype branch 3 times, most recently from 8a622f6 to 50c52d3 Compare September 8, 2025 18:30
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 50a41c7 to 27003da Compare September 11, 2025 18:42
Base automatically changed from fhe-SNOW-2272863-support-daytimeintervaltype to main September 11, 2025 20:55
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 596a3cb to f5abd67 Compare September 11, 2025 20:58
@sfc-gh-fhe sfc-gh-fhe marked this pull request as ready for review September 11, 2025 20:58
@sfc-gh-fhe sfc-gh-fhe requested review from a team as code owners September 11, 2025 20:58
Comment thread src/snowflake/snowpark/functions.py Outdated
Comment thread src/snowflake/snowpark/functions.py Outdated
Comment thread src/snowflake/snowpark/functions.py Outdated
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 85dd8e6 to 43328ac Compare September 11, 2025 22:28
@sfc-gh-fhe sfc-gh-fhe force-pushed the fhe-SNOW-2296280-add-make_dt_interval-function branch from 7a480d3 to f24d9fe Compare September 15, 2025 20:29
Comment thread src/snowflake/snowpark/functions.py Outdated

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question, but LGTM otherwise!

Comment thread src/snowflake/snowpark/functions.py
@sfc-gh-yuwang sfc-gh-yuwang merged commit 3da0012 into main Sep 16, 2025
43 of 47 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the fhe-SNOW-2296280-add-make_dt_interval-function branch September 16, 2025 20:15
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants