Skip to content

SNOW-2241408: finer grade telemetry for dbapi#3745

Merged
sfc-gh-yuwang merged 5 commits into
mainfrom
SNOW-2241408
Sep 30, 2025
Merged

SNOW-2241408: finer grade telemetry for dbapi#3745
sfc-gh-yuwang merged 5 commits into
mainfrom
SNOW-2241408

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang sfc-gh-yuwang added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 10, 2025
@sfc-gh-yuwang sfc-gh-yuwang marked this pull request as ready for review September 10, 2025 23:17
@sfc-gh-yuwang sfc-gh-yuwang requested review from a team as code owners September 10, 2025 23:17
Comment thread src/snowflake/snowpark/dataframe_reader.py Outdated
Comment thread src/snowflake/snowpark/_internal/data_source/utils.py Outdated
Comment thread tests/integ/test_data_source_api.py Outdated
Comment thread tests/integ/test_data_source_api.py Outdated
@sfc-gh-aling

Copy link
Copy Markdown
Collaborator

as per our discussion, let's just log first not sending the telemetry events

@sfc-gh-yuwang sfc-gh-yuwang merged commit bcb81a9 into main Sep 30, 2025
29 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-2241408 branch September 30, 2025 16:47
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants