SNOW-2313015: add support for session init statement in udtf ingestion of dbapi#3748
Merged
Conversation
Collaborator
There was a problem hiding this comment.
I think there is actionable item that if we don't supporting setting query_timeout for a DBMS, we should let users know that they need to find ways to set by themselves.
this can be done in a separate jira
8a35398 to
28f08b4
Compare
sfc-gh-aling
approved these changes
Sep 12, 2025
sfc-gh-jrose
approved these changes
Sep 16, 2025
|
|
||
|
|
||
| def test_oracledb_driver_udtf_class_builder(): | ||
| """Test the UDTF class builder in Psycopg2Driver using a real PostgreSQL connection""" |
Contributor
There was a problem hiding this comment.
The docstring incorrectly references Psycopg2Driver when this test is actually for the OracledbDriver. Please update the docstring to accurately reflect the driver being tested.
Suggested change
| """Test the UDTF class builder in Psycopg2Driver using a real PostgreSQL connection""" | |
| """Test the UDTF class builder in OracledbDriver using a real Oracle database connection""" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.