Skip to content

SNOW-2313015: add support for session init statement in udtf ingestion of dbapi#3748

Merged
sfc-gh-yuwang merged 17 commits into
mainfrom
SNOW-2313015
Sep 23, 2025
Merged

SNOW-2313015: add support for session init statement in udtf ingestion of dbapi#3748
sfc-gh-yuwang merged 17 commits into
mainfrom
SNOW-2313015

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Comment thread CHANGELOG.md Outdated
Comment thread src/snowflake/snowpark/_internal/data_source/datasource_reader.py Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is actionable item that if we don't supporting setting query_timeout for a DBMS, we should let users know that they need to find ways to set by themselves.

this can be done in a separate jira

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a jira to track: SNOW-2331978

Comment thread src/snowflake/snowpark/_internal/data_source/drivers/pymsql_driver.py Outdated
Comment thread src/snowflake/snowpark/_internal/data_source/drivers/pymsql_driver.py Outdated
Comment thread tests/integ/datasource/test_oracledb.py Outdated
Comment thread tests/integ/datasource/test_mysql.py Outdated
Comment thread src/snowflake/snowpark/_internal/data_source/drivers/oracledb_driver.py Outdated
Comment thread tests/integ/test_data_source_api.py
Comment thread CHANGELOG.md
@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner September 18, 2025 21:30
Comment thread src/snowflake/snowpark/_internal/data_source/drivers/base_driver.py
Comment thread src/snowflake/snowpark/_internal/data_source/drivers/psycopg2_driver.py Outdated
Comment thread tests/integ/datasource/test_oracledb.py Outdated


def test_oracledb_driver_udtf_class_builder():
"""Test the UDTF class builder in Psycopg2Driver using a real PostgreSQL connection"""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring incorrectly references Psycopg2Driver when this test is actually for the OracledbDriver. Please update the docstring to accurately reflect the driver being tested.

Suggested change
"""Test the UDTF class builder in Psycopg2Driver using a real PostgreSQL connection"""
"""Test the UDTF class builder in OracledbDriver using a real Oracle database connection"""

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@sfc-gh-yuwang sfc-gh-yuwang merged commit ed4199a into main Sep 23, 2025
27 of 28 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-2313015 branch September 23, 2025 00:01
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants