SNOW-2263127: Add AST support for AI functions #3761
Merged
Merged
Conversation
sfc-gh-jdu
requested review from
sfc-gh-mayliu,
sfc-gh-yixie and
sfc-gh-yuwang
and removed request for
a team
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
sfc-gh-jrose
approved these changes
Sep 11, 2025
sfc-gh-heshah
requested changes
Sep 11, 2025
| build_expr_from_python_val(ast.cols.args.add(), task_description) | ||
| # Set arguments | ||
| build_expr_from_python_val(ast.expr, expr) | ||
| ast.task_description = task_description |
Collaborator
There was a problem hiding this comment.
Do we not need to capture **kwargs in the AST here?
Collaborator
Author
There was a problem hiding this comment.
it seems all methods in this class have kwargs but they are not captured in AST code. Maybe we can have a separate PR for it?
Collaborator
There was a problem hiding this comment.
Yes, that's a good idea.
sfc-gh-heshah
requested changes
Sep 11, 2025
| build_expr_from_python_val(ast.cols.args.add(), task_description) | ||
| # Set arguments | ||
| build_expr_from_python_val(ast.expr, expr) | ||
| ast.task_description = task_description |
Collaborator
There was a problem hiding this comment.
Yes, that's a good idea.
sfc-gh-heshah
approved these changes
Sep 11, 2025
sfc-gh-heshah
left a comment
sfc-gh-heshah
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2263127
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.