SNOW-2314365: Added support for conditional expression functions#3767
Merged
sfc-gh-aherreraaguilar merged 29 commits intoSep 19, 2025
Merged
Conversation
sfc-gh-aherreraaguilar
requested review from
sfc-gh-mayliu,
sfc-gh-yixie and
sfc-gh-yuwang
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
…ditional-expression-functions
…nditional-expression-functions' into feature/aherrera/SNOW-2314365-conditional-expression-functions
…ditional-expression-functions
sfc-gh-aherreraaguilar
changed the title
…ditional-expression-functions # Conflicts: # CHANGELOG.md # src/snowflake/snowpark/_functions/scalar_functions.py
…pression-functions
sfc-gh-mvegaalvarez
requested changes
Sep 12, 2025
There was a problem hiding this comment.
code looks good,
added several comments regarding documentation of methods, should use a consistent way to document all the methods
my suggestion:
Args:
<argName> (<type>): <description of the arg, without references to the type no>
Returns:
<returnType>: <description of return value, without reference to the type>
Contributor
Author
|
@sfc-gh-mvegaalvarez comments solved |
sfc-gh-aling
approved these changes
Sep 17, 2025
Collaborator
|
oops looks like local testing failed due to the new function support |
Contributor
Author
|
Hello @sfc-gh-aling, I made some updates to fix the local testing failure. Please take a look. Thanks! |
…pression-functions
…pression-functions # Conflicts: # docs/source/snowpark/functions.rst # src/snowflake/snowpark/_functions/scalar_functions.py
sfc-gh-aherreraaguilar
deleted the
feature/aherrera/SNOW-2314365-conditional-expression-functions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2314365
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
functions.py:boolandboolnotboolorboolxordecodegreatest_ignore_nullsleast_ignore_nullsnullifnvl2regr_valx