Skip to content

SNOW-2333111: Add support for Geospatial functions - part 1#3769

Merged
sfc-gh-aherreraaguilar merged 16 commits into
mainfrom
feature/aherrera/SNOW-2333111-geospatial-part1
Sep 22, 2025
Merged

SNOW-2333111: Add support for Geospatial functions - part 1#3769
sfc-gh-aherreraaguilar merged 16 commits into
mainfrom
feature/aherrera/SNOW-2333111-geospatial-part1

Conversation

@sfc-gh-aherreraaguilar

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar commented Sep 11, 2025

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2333111

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

  • Added support for the following scalar functions in functions.py:
    • h3_polygon_to_cells
    • h3_polygon_to_cells_strings
    • h3_string_to_int
    • h3_try_polygon_to_cells_strings
    • h3_cell_to_children
    • h3_cell_to_children_string
    • h3_int_to_string

Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
…spatial-part1

# Conflicts:
#	CHANGELOG.md
#	src/snowflake/snowpark/_functions/scalar_functions.py
…ospatial-part1' into feature/aherrera/SNOW-2333111-geospatial-part1

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good
added several comments regarding the documentation consistency

my suggestion for the Args and Returns format, you can use another, but stick to it and be consistent:

Args:
    <argName> (<type>): <description of the arg, without references to the type no> 
Returns:
    <returnType>: <description of return value, without reference to the type>

Comment thread CHANGELOG.md Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
@sfc-gh-aherreraaguilar

Copy link
Copy Markdown
Contributor Author

@sfc-gh-mvegaalvarez comments solved

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar merged commit 372060a into main Sep 22, 2025
29 checks passed
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar deleted the feature/aherrera/SNOW-2333111-geospatial-part1 branch September 22, 2025 15:33
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants