SNOW-2333472: More hybrid benchmark fixes#3771
Merged
Merged
Conversation
sfc-gh-jkew
approved these changes
Sep 15, 2025
sfc-gh-helmeleegy
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2333472
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR addresses failures in
renameand settingindex(items 1 and 2 in the ticket). Items 3 and 4 are test setup issues, addressed in the benchmarking repo here: https://github.com/snowflakedb/snowpark-pandas-performance/pull/105.I reran the hybrid CSV generation as well, but the size of the csv file increased, possibly due to other pandas tests being added before this PR was made. I'll omit updates to it for now, but we may want to do a more comprehensive audit to find internal points where we should use
new_snow_series/new_snow_df(which disable auto-switching) instead ofpd.Series/pd.DataFrame, since glancing at the error output seemed to indicate a large body of those errors.We cannot do a bulk find-and-replace for these constructors, since in some cases wrapping a result in a Series/DF is the last operation before returning from a frontend method, and auto-switching may or may not be desirable. However, this is arguably a bug since explicit switching should only be decided by the QC caster; if so, we should consider updating modin to always disable casting before calling a frontend method.