Skip to content

SNOW-2220946: Add support for unstructured data engineering in Snowpark#3775

Merged
sfc-gh-jdu merged 13 commits into
mainfrom
ai
Sep 16, 2025
Merged

SNOW-2220946: Add support for unstructured data engineering in Snowpark#3775
sfc-gh-jdu merged 13 commits into
mainfrom
ai

Conversation

@sfc-gh-jdu

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2220946

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    see changelog

WriteParquet write_parquet = 182;
WriteSave write_save = 183;
WriteTable write_table = 184;
DataframeAiAgg dataframe_ai_agg = 47;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we concerned with these constants changing? Normally I would add to the end and increment to prevent version incompatibilities but I'm not sure if it matters with how the AST is used today.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AST change was already reviewed in this PR https://github.com/snowflakedb/snowpark-python/pull/3761/files

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated, the constants shouldn't pose any issues until we start versioning the AST.

Comment thread CHANGELOG.md
@@ -1,5 +1,29 @@
# Release History

## 1.40.0 (YYYY-MM-DD)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't want this to go out with 1.39.0?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea 1.39 will be this week, right? I'm not sure whether we can finish review by this week.

def __init__(self, dataframe: "snowflake.snowpark.DataFrame") -> None:
self._dataframe = dataframe

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also need to be changed to 1.39 if want to included in this release

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

filtered_df._ast_id = stmt.uid
return filtered_df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

df._ast_id = stmt.uid
return df

@experimental(version="1.40.0")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some place need to change below

@sfc-gh-heshah sfc-gh-heshah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-jdu sfc-gh-jdu merged commit b77dc73 into main Sep 16, 2025
26 of 29 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the ai branch September 16, 2025 20:03
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants