Skip to content

Snow 2324796 secrets api migration 1#3781

Merged
sfc-gh-mayliu merged 9 commits into
mainfrom
SNOW-2324796-secrets-api-migration-1
Sep 18, 2025
Merged

Snow 2324796 secrets api migration 1#3781
sfc-gh-mayliu merged 9 commits into
mainfrom
SNOW-2324796-secrets-api-migration-1

Conversation

@sfc-gh-mayliu

@sfc-gh-mayliu sfc-gh-mayliu commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2324796

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Comment thread src/snowflake/snowpark/secrets.py
Comment thread src/snowflake/snowpark/secrets.py Outdated
Comment thread src/snowflake/snowpark/secrets.py
Comment thread tests/integ/test_secrets.py
Comment thread docs/source/snowpark/secrets.rst
Comment thread CHANGELOG.md Outdated
token: str


@publicapi

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-heshah do we need @publicapi in this case?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary because the API doesn't interact with AST or have an _emit_ast parameter, but it shouldn't necessarily be harmful either.

Comment thread src/snowflake/snowpark/secrets.py
@sfc-gh-mayliu sfc-gh-mayliu merged commit d99fdfa into main Sep 18, 2025
29 checks passed
@sfc-gh-mayliu sfc-gh-mayliu deleted the SNOW-2324796-secrets-api-migration-1 branch September 18, 2025 17:21
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants