SNOW-2331792: Support DataFrame.eval for single-level index.#3782
Merged
sfc-gh-mvashishtha merged 5 commits intoSep 18, 2025
Merged
Conversation
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-jkew
reviewed
Sep 17, 2025
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-joshi
approved these changes
Sep 17, 2025
sfc-gh-jkew
approved these changes
Sep 17, 2025
sfc-gh-lmukhopadhyay
approved these changes
Sep 17, 2025
sfc-gh-lmukhopadhyay
left a comment
Contributor
There was a problem hiding this comment.
Added one comment, else LGTM
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support all the parameters of
DataFrame.evalvia the Modin implementation. Only support single-level row index for now because the MultiIndex is currently a pandas object, so we have to get resolvers for its levels differently.