Skip to content

SNOW-2331792: Support DataFrame.eval for single-level index.#3782

Merged
sfc-gh-mvashishtha merged 5 commits into
mainfrom
mvashishtha/SNOW-2331792/support-dataframe-eval
Sep 18, 2025
Merged

SNOW-2331792: Support DataFrame.eval for single-level index.#3782
sfc-gh-mvashishtha merged 5 commits into
mainfrom
mvashishtha/SNOW-2331792/support-dataframe-eval

Conversation

@sfc-gh-mvashishtha

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Support all the parameters of DataFrame.eval via the Modin implementation. Only support single-level row index for now because the MultiIndex is currently a pandas object, so we have to get resolvers for its levels differently.

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Comment thread src/snowflake/snowpark/modin/plugin/utils/warning_message.py Outdated
Comment thread tests/integ/modin/frame/test_eval.py Outdated
Comment thread tests/integ/modin/frame/test_eval.py
Comment thread tests/integ/modin/frame/test_eval.py
Comment thread tests/integ/modin/frame/test_eval.py
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Comment thread src/snowflake/snowpark/modin/plugin/utils/warning_message.py Outdated
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Comment thread src/snowflake/snowpark/modin/plugin/_internal/utils.py
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Comment thread src/snowflake/snowpark/modin/plugin/_internal/utils.py

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment, else LGTM

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit ba2d66f into main Sep 18, 2025
28 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-2331792/support-dataframe-eval branch September 18, 2025 00:57
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants