Skip to content

[POC] Enabled auto switching on unimplemented parameters for cumsum#3787

Closed
sfc-gh-jenzhang wants to merge 38 commits into
mainfrom
poc-notimplemented-params
Closed

[POC] Enabled auto switching on unimplemented parameters for cumsum#3787
sfc-gh-jenzhang wants to merge 38 commits into
mainfrom
poc-notimplemented-params

Conversation

@sfc-gh-jenzhang

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2325411

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Comment on lines +457 to +465
@register_base_not_implemented(
unsupported_kwargs=UnsupportedKwargsRule(
conditions={
"axis": lambda x: x
== 1, # axis=1 raises NotImplementedError in query compiler
},
default_values={"axis": 0},
)
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to add these manually for most of the methods?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible approach is this. Another would be to use the SOT files
, parse it, and store the results somewhere (perhaps with a job that automatically refreshes when the SOT updates). That said, this option introduces more overhead. Since we already manually add register_base_not_implemented for unimplemented methods, extending it to include unsupported kwargs may not add significant extra work.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants