[POC] Enabled auto switching on unimplemented parameters for cumsum#3787
Closed
sfc-gh-jenzhang wants to merge 38 commits into
Closed
[POC] Enabled auto switching on unimplemented parameters for cumsum#3787sfc-gh-jenzhang wants to merge 38 commits into
sfc-gh-jenzhang wants to merge 38 commits into
Conversation
…edb/snowpark-python into cortex-complete-feature
Co-authored-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
…edb/snowpark-python into cortex-complete-feature
…into poc-notimplemented-params
Comment on lines
+457
to
+465
| @register_base_not_implemented( | ||
| unsupported_kwargs=UnsupportedKwargsRule( | ||
| conditions={ | ||
| "axis": lambda x: x | ||
| == 1, # axis=1 raises NotImplementedError in query compiler | ||
| }, | ||
| default_values={"axis": 0}, | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
Are you planning to add these manually for most of the methods?
Contributor
Author
There was a problem hiding this comment.
One possible approach is this. Another would be to use the SOT files
, parse it, and store the results somewhere (perhaps with a job that automatically refreshes when the SOT updates). That said, this option introduces more overhead. Since we already manually add register_base_not_implemented for unimplemented methods, extending it to include unsupported kwargs may not add significant extra work.
…akedb/snowpark-python into poc-notimplemented-params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2325411
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.