Skip to content

NO-SNOW: Fix local test on windows.#3796

Merged
sfc-gh-jrose merged 1 commit into
mainfrom
jrose_snow_no_fix_daily_precommit_20250922
Sep 22, 2025
Merged

NO-SNOW: Fix local test on windows.#3796
sfc-gh-jrose merged 1 commit into
mainfrom
jrose_snow_no_fix_daily_precommit_20250922

Conversation

@sfc-gh-jrose

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    This PR disables some failing tests on windows. Pytest always creates its tmp_path on the C: drive. The tests are mounted into docker as a separate drive. Windows does not support creating a relpath between drives so this case will always fail.

@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner September 22, 2025 18:40
@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 22, 2025
@sfc-gh-jrose sfc-gh-jrose merged commit 3b5cce5 into main Sep 22, 2025
35 of 36 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_no_fix_daily_precommit_20250922 branch September 22, 2025 20:51
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants