Skip to content

NO SNOW: modify SNOW-2303618 changelog and skip test on snowfort#3801

Merged
sfc-gh-yuwang merged 5 commits into
mainfrom
SNOW-2303618-yuwang
Sep 26, 2025
Merged

NO SNOW: modify SNOW-2303618 changelog and skip test on snowfort#3801
sfc-gh-yuwang merged 5 commits into
mainfrom
SNOW-2303618-yuwang

Conversation

@sfc-gh-yuwang

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Comment thread tests/integ/test_dataframe.py Outdated
reason="Not supported in local testing ",
)
@pytest.mark.skipif(
IS_NOT_ON_GITHUB,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to skip in stored proc? jenkins job should work as it's in client mode

Comment thread tests/integ/test_dataframe.py Outdated
Comment thread CHANGELOG.md Outdated
#### Bug Fixes

- Fixed a bug that `DataFrame.limit()` fail if there is parameter binding in the executed SQL.
- Fixed a bug that `DataFrame.limit()` fail if there is parameter binding in the executed SQL when used in local environment.

@sfc-gh-aling sfc-gh-aling Sep 25, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"local environment" is not clear to users to what it means. let's make it clear it's fixed in non storedproc/udxf environment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, when you make the change, can you help move the "Bug Fixes" section after the "New Features"?

@sfc-gh-yuwang sfc-gh-yuwang merged commit 921bc70 into main Sep 26, 2025
29 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-2303618-yuwang branch September 26, 2025 18:04
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants