NO SNOW: modify SNOW-2303618 changelog and skip test on snowfort#3801
Merged
Conversation
sfc-gh-yuwang
requested review from
sfc-gh-aalam,
sfc-gh-jdu and
sfc-gh-jrose
| reason="Not supported in local testing ", | ||
| ) | ||
| @pytest.mark.skipif( | ||
| IS_NOT_ON_GITHUB, |
Collaborator
There was a problem hiding this comment.
I think we just need to skip in stored proc? jenkins job should work as it's in client mode
| #### Bug Fixes | ||
|
|
||
| - Fixed a bug that `DataFrame.limit()` fail if there is parameter binding in the executed SQL. | ||
| - Fixed a bug that `DataFrame.limit()` fail if there is parameter binding in the executed SQL when used in local environment. |
Collaborator
There was a problem hiding this comment.
"local environment" is not clear to users to what it means. let's make it clear it's fixed in non storedproc/udxf environment
Collaborator
There was a problem hiding this comment.
nit, when you make the change, can you help move the "Bug Fixes" section after the "New Features"?
sfc-gh-aling
approved these changes
Sep 25, 2025
sfc-gh-mayliu
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.