Skip to content

NO SNOW: modify SNOW-2303618 changelog and skip test on snowfort #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-yuwang merged 5 commits into from
Sep 26, 2025
Merged

NO SNOW: modify SNOW-2303618 changelog and skip test on snowfort #3801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f07a7f3
t
sfc-gh-yuwang Sep 23, 2025
829e7df
fix
sfc-gh-yuwang Sep 23, 2025
018cde8
Merge branch 'main' into SNOW-2303618-yuwang
sfc-gh-yuwang Sep 24, 2025
fa3eb6d
Merge branch 'main' into SNOW-2303618-yuwang
sfc-gh-yuwang Sep 25, 2025
c92eed6
fix changelog
sfc-gh-yuwang Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#### Bug Fixes

- Fixed a bug that `DataFrame.limit()` fail if there is parameter binding in the executed SQL.
- Fixed a bug that `DataFrame.limit()` fail if there is parameter binding in the executed SQL when used in non-stored-procedure/udxf environment.
- Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types.

#### New Features
Expand Down
4 changes: 4 additions & 0 deletions tests/integ/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4694,6 +4694,10 @@ def test_limit_offset(session):
"config.getoption('local_testing_mode', default=False)",
reason="Not supported in local testing ",
)
@pytest.mark.skipif(
IS_IN_STORED_PROC,
reason="SNOW-2356885: this is not fixed on sp/udxf",
)
def test_limit_param_binding(session):
table_name = Utils.random_name_for_temp_object(TempObjectType.TABLE)
session.create_dataframe(
Expand Down