SNOW-2360274: Fix schema query sql generation for structured types#3804
Merged
sfc-gh-jrose merged 7 commits intoSep 25, 2025
Merged
Conversation
sfc-gh-aling
approved these changes
Sep 24, 2025
sfc-gh-mayliu
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2360274
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The sql generation for describe queries has an edge case that can cause invalid sql to be generated when using nested structured types. The schema_expression function does it's best to respect nullability when generating schema queries. Snowflake does not support nullability inside of structured types so this should not be needed for structured types. This fix short circuits the sql generation by replacing the recursive call with NULLs. I have not found any cases in which this would break, but to be extra sure it's not a BCR I am gating it behind a context variable. In order to use this bugfix you will have to set
context. _enable_fix_2360274to be True.