SNOW-2356405: dbapi pyodbc and udtf fixes#3805
Merged
sfc-gh-aling merged 10 commits intoSep 26, 2025
Merged
Conversation
…on-perf-vs-jdbc-perf
…ocal-ingestion-perf-vs-jdbc-perf' into SNOW-2356405-dbapi-stored-proc-local-ingestion-perf-vs-jdbc-perf
7fa1665 to
c017657
Compare
sfc-gh-aalam
approved these changes
Sep 25, 2025
Collaborator
|
should we also trigger a snowfort test to verify this change is safe for server? |
sfc-gh-yuwang
approved these changes
Sep 25, 2025
sfc-gh-yuwang
left a comment
Collaborator
There was a problem hiding this comment.
pre-approval assume changelog nint will be fixed
Collaborator
Author
|
@sfc-gh-yuwang we can and I just triggered. I will do extra manual test to ensure the features work as expected in the sproc env. |
sfc-gh-mayliu
approved these changes
Sep 25, 2025
|
|
||
| class SqlServerDialect(BaseDialect): | ||
| pass | ||
| def generate_select_query( |
Collaborator
There was a problem hiding this comment.
Curious about how this is used, is it related to the bug fixes?
Collaborator
Author
There was a problem hiding this comment.
it is related to the bug query input does not work for SQL Server.
default base driver add backtik to column name which is invalid in sql server.
the fix is to use double quote
Collaborator
Author
There was a problem hiding this comment.
I updated the changelog, hope the bug is easier to understand now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
DataFrameReader.dbapi(PuPr):pyodbcdriver.DataFrameReader.dbapi(PuPr) reading performance by setting the defaultfetch_sizeparameter value to 10000.Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.