Skip to content

SNOW-2261400: Fix incorrect join condition in repeated subquery elimination #3808

Merged
sfc-gh-jdu merged 3 commits into
mainfrom
jdu-fix-cte-id
Sep 26, 2025
Merged

SNOW-2261400: Fix incorrect join condition in repeated subquery elimination #3808
sfc-gh-jdu merged 3 commits into
mainfrom
jdu-fix-cte-id

Conversation

@sfc-gh-jdu

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2261400

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Now we consider the dataframe with the same query but different alias map as different, as they will have different join conditions in parent queries.

@sfc-gh-jdu sfc-gh-jdu requested review from a team as code owners September 25, 2025 21:47
@sfc-gh-jdu sfc-gh-jdu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 25, 2025
@sfc-gh-jdu sfc-gh-jdu merged commit 3db0617 into main Sep 26, 2025
28 of 29 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-fix-cte-id branch September 26, 2025 21:03
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants