Skip to content

SNOW-2364008: Remove unnecessary warning for XML reader and xpath function #3812

Merged
sfc-gh-jdu merged 1 commit into
mainfrom
jdu-SNOW-2364008-xml-warning
Sep 29, 2025
Merged

SNOW-2364008: Remove unnecessary warning for XML reader and xpath function #3812
sfc-gh-jdu merged 1 commit into
mainfrom
jdu-SNOW-2364008-xml-warning

Conversation

@sfc-gh-jdu

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2364008

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

This pull request removes unnecessary warnings about local package version mismatches when using the rowTag option for XML reading and the xpath function, both of which are in private preview. It introduces an internal mechanism to suppress these warnings in relevant scenarios, updates the codebase to support this, and adds tests to ensure the warnings are properly suppressed.

Warning suppression improvements:

  • Removed warnings about local package version mismatches when using session.read.option('rowTag', <tag_name>).xml(<stage_file_path>) and xpath functions, as these features are in private preview and the warnings are not needed for end users. [1] [2]
  • Added an internal _suppress_local_package_warnings flag to package resolution logic and updated all relevant registration and reading functions to accept and pass this flag through, ensuring warnings are suppressed where appropriate.

Testing enhancements:

  • Added integration and unit tests to verify that local package version mismatch warnings are not emitted when using the XML rowTag option and xpath functions, and that the suppression mechanism works as intended.

@sfc-gh-jdu sfc-gh-jdu merged commit 2e44cc0 into main Sep 29, 2025
34 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-SNOW-2364008-xml-warning branch September 29, 2025 19:03
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants