SNOW-2364943: support export external telemetry to event table#3813
Merged
Conversation
sfc-gh-yuwang
requested review from
sfc-gh-jrose,
sfc-gh-mayliu and
sfc-gh-yixie
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
sfc-gh-vguttha
approved these changes
Oct 16, 2025
sfc-gh-vguttha
left a comment
sfc-gh-vguttha
left a comment
There was a problem hiding this comment.
Pls address the doc comments. Rest LGTM. Thanks for doing this.
| return self._sp_profiler | ||
|
|
||
| @property | ||
| def client_telemetry(self) -> ExternalTelemetry: |
Contributor
There was a problem hiding this comment.
should we rename to EventTableTelemetry to make it consistent?
| # test with mock exporter and authentication | ||
| with ( | ||
| patch( | ||
| "snowflake.snowpark._internal.external_telemetry.create_attestation", |
Contributor
There was a problem hiding this comment.
The patch path in the test doesn't match the actual module path. It should be snowflake.snowpark._internal.event_table_telemetry.create_attestation to match the import at line 10 of the event_table_telemetry.py file. This mismatch would cause the test to fail since the mock won't intercept the actual function call.
Suggested change
| "snowflake.snowpark._internal.external_telemetry.create_attestation", | |
| "snowflake.snowpark._internal.event_table_telemetry.create_attestation", |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
sfc-gh-sying
approved these changes
Oct 22, 2025
| ext.enable_event_table_telemetry_collection("snowflake.telemetry.events", logging.INFO, True) | ||
| tracer = trace.get_tracer("my_tracer") | ||
| with tracer.start_as_current_span("code_store") as span: | ||
| span.set_attribute("code.lineno", "21") |
Contributor
There was a problem hiding this comment.
Suggested change
| span.set_attribute("code.lineno", "21") | |
| span.set_attribute("code.lineno", "21") |
| logging.info("Trace being sent to event table") | ||
| ext.disable_event_table_telemetry_collection() | ||
| logging.info("out of scope log") # this log is not sent to event table | ||
| ext.enable_event_table_telemetry_collection("db.sc.external_et", logging.DEBUG, True) |
Contributor
There was a problem hiding this comment.
Suggested change
| ext.enable_event_table_telemetry_collection("db.sc.external_et", logging.DEBUG, True) | |
| ext.enable_event_table_telemetry_collection("snowflake.telemetry.events", logging.DEBUG, True) |
| logging.info("Trace being sent to event table") | ||
| ext.disable_event_table_telemetry_collection() | ||
| logging.info("out of scope log") # this log is not sent to event table | ||
| ext.enable_event_table_telemetry_collection("db.sc.external_et", logging.DEBUG, True) |
Contributor
There was a problem hiding this comment.
Suggested change
| ext.enable_event_table_telemetry_collection("db.sc.external_et", logging.DEBUG, True) | |
| ext.enable_event_table_telemetry_collection("snowflake.telemetry.events", logging.DEBUG, True) |
sfc-gh-aalam
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2364943
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR aim to add feature of sending external telemetry information(trace/log) to an event table with open telemetry library.
Here is the design doc of this feature:https://docs.google.com/document/d/1xUbIz5F-Bq3k5dt19SJN5dIy4QnvbQJ-Prq7pscEyAM/edit?usp=sharing