Skip to content

SNOW-2371712: Add support for geospatial functions (part 5)#3817

Merged
sfc-gh-aherreraaguilar merged 8 commits into
mainfrom
feature/aherrera/SNOW-2371712-GeospatialPart5
Oct 1, 2025
Merged

SNOW-2371712: Add support for geospatial functions (part 5)#3817
sfc-gh-aherreraaguilar merged 8 commits into
mainfrom
feature/aherrera/SNOW-2371712-GeospatialPart5

Conversation

@sfc-gh-aherreraaguilar

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar commented Sep 29, 2025

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2371712

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

Adds support for scalar geospatial functions:

  • st_aswkt
  • st_azimuth
  • st_buffer
  • st_centroid
  • st_collect
  • st_contains
  • st_coveredby
  • st_covers
  • st_difference
  • st_dimension

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, added minor comments, one regarding a missing test, and the others with the missed :: after the Examples text on several docstrings.

Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar merged commit d2c6216 into main Oct 1, 2025
28 checks passed
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar deleted the feature/aherrera/SNOW-2371712-GeospatialPart5 branch October 1, 2025 20:35
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants