Skip to content

SNOW-2380792: Fix modin CI.#3825

Merged
sfc-gh-mvashishtha merged 5 commits into
mainfrom
mvashishtha/SNOW-2380792/fix-modin-inplace-eval-xfail
Oct 1, 2025
Merged

SNOW-2380792: Fix modin CI.#3825
sfc-gh-mvashishtha merged 5 commits into
mainfrom
mvashishtha/SNOW-2380792/fix-modin-inplace-eval-xfail

Conversation

@sfc-gh-mvashishtha

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Add some changes that we need to support Modin 0.37.0:

  • add a Snowflake extension for Series.to_json that raises NotImplementedError.
  • test_inplace_false_with_assignment_does_not_mutate_df now passes
  • change some expectations relating to merges

sfc-gh-mvashishtha and others added 2 commits October 1, 2025 06:04
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 30, 2025
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review September 30, 2025 23:01
@sfc-gh-mvashishtha sfc-gh-mvashishtha requested a review from a team as a code owner September 30, 2025 23:01
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 183a392 into main Oct 1, 2025
34 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-2380792/fix-modin-inplace-eval-xfail branch October 1, 2025 03:30
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants