Skip to content

Fix SnowparkPythonSnowflakePythonClientRegressRunner #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-jdu merged 5 commits into from
Oct 1, 2025
Merged

Fix SnowparkPythonSnowflakePythonClientRegressRunner #3826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
972b120
d
sfc-gh-jdu Sep 30, 2025
3bfa263
d
sfc-gh-jdu Sep 30, 2025
330a131
d
sfc-gh-jdu Sep 30, 2025
12b1d12
d
sfc-gh-jdu Sep 30, 2025
761a921
fix
sfc-gh-jdu Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/jenkins_regress.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ gpg --quiet --batch --yes --decrypt --passphrase="$GPG_KEY" --output "tests/para
pip install protoc-wheel-0==21.1 mypy-protobuf

# Run linter, Python test and code coverage jobs
exit_code_decorator "python -m tox -c $WORKING_DIR" -e notdoctest-pyarrowcap
exit_code_decorator "python -m tox -c $WORKING_DIR" -e notdoctest-pandascap-pyarrowcap
12 changes: 6 additions & 6 deletions tests/unit/test_packaging_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def test_get_downloaded_packages_for_real_python_packages(temp_directory):
Assert that for genuine pypi packages, get_downloaded_packages() actually picks up the correct package names.
To avoid flakiness, we only check for package names.
"""
packages = ["requests", "numpy", "pandas"]
packages = ["requests", "numpy"]
target_folder = os.path.join(temp_directory, "packages")
pip_install_packages_to_target_folder(packages, target_folder)
for package in packages:
Expand All @@ -148,9 +148,9 @@ def test_get_downloaded_packages_for_real_python_packages(temp_directory):
)
package_names = {package.name for package in downloaded_packages_dict.keys()}
for package_name in packages + [
"six",
"pytz",
]: # six and pytz are integral dependencies
"certifi",
"urllib3",
]: # certifi and urllib3 are integral dependencies
assert package_name in package_names


Expand All @@ -162,7 +162,7 @@ def test_pip_timeout(temp_directory):
"""
Assert that timeout parameter works fine.
"""
packages = ["requests", "numpy", "pandas"]
packages = ["requests", "numpy"]
target_folder = os.path.join(temp_directory, "packages")
with pytest.raises(TimeoutExpired):
pip_install_packages_to_target_folder(packages, target_folder, timeout=1)
Expand Down Expand Up @@ -295,7 +295,7 @@ def test_identify_supported_packages_all_cases():
reason="Subprocess calls are not allowed within stored procedures",
)
def test_valid_pip_install(temp_directory):
packages = ["requests", "numpy", "pandas"]
packages = ["requests", "numpy"]
target_folder = os.path.join(temp_directory, "packages")
pip_install_packages_to_target_folder(packages, target_folder)
for package in packages:
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ allowlist_externals = bash
description = run the tests with pytest under {basepython}
deps =
{env:SNOWFLAKE_PYTEST_MODIN_JENKINS_PYARROW_CAP}
{env:SNOWFLAKE_PYTEST_MODIN_JENKINS_PANDAS_CAP}
pip >= 19.3.1
pytest-xdist
pytest-timeout
Expand Down Expand Up @@ -90,6 +91,7 @@ setenv =
# Cap pyarrow<21 for Snowpark pandas tests on Jenkins due to SNOW-2266293
snowparkpandasjenkins: SNOWFLAKE_PYTEST_MODIN_JENKINS_PYARROW_CAP = pyarrow<21
pyarrowcap: SNOWFLAKE_PYTEST_MODIN_JENKINS_PYARROW_CAP = pyarrow<21
pandascap: SNOWFLAKE_PYTEST_MODIN_JENKINS_PANDAS_CAP = pandas<=2.3.2

passenv =
AWS_ACCESS_KEY_ID
Expand Down
Loading