Skip to content

SNOW-2380327: Add support for scalar geospatial functions - part6#3827

Merged
sfc-gh-aherreraaguilar merged 12 commits into
mainfrom
feature/aherrera/SNOW-2380327-GeospatialPart6
Oct 8, 2025
Merged

SNOW-2380327: Add support for scalar geospatial functions - part6#3827
sfc-gh-aherreraaguilar merged 12 commits into
mainfrom
feature/aherrera/SNOW-2380327-GeospatialPart6

Conversation

@sfc-gh-aherreraaguilar

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar commented Oct 1, 2025 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2380327

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

Adds support for scalar geospatial functions:

  • st_disjoint
  • st_distance
  • st_dwithin
  • st_endpoint
  • st_envelope
  • st_geohash
  • st_geomfromgeohash
  • st_geompointfromgeohash
  • st_hausdorffdistance
  • st_makepoint

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar requested review from a team as code owners October 1, 2025 16:03
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar changed the title Add support for scalar geospatial functions - part6 SNOW-2380327: Add support for scalar geospatial functions - part6 Oct 1, 2025
sfc-gh-mvegaalvarez
sfc-gh-mvegaalvarez requested changes Oct 1, 2025
View reviewed changes

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments, several typehints are missing, and improve on the geo parameter names and docstring explicitness

Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
@sfc-gh-aherreraaguilar
Fix comments
6893b17
@sfc-gh-aherreraaguilar
Merge branch 'main' into feature/aherrera/SNOW-2380327-GeospatialPart6
bf1d0f2 
# Conflicts:
#	CHANGELOG.md
#	docs/source/snowpark/functions.rst
#	src/snowflake/snowpark/_functions/scalar_functions.py
sfc-gh-aling
sfc-gh-aling reviewed Oct 7, 2025
View reviewed changes
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py
sfc-gh-aling
sfc-gh-aling reviewed Oct 7, 2025
View reviewed changes
Comment thread src/snowflake/snowpark/_functions/scalar_functions.py Outdated
sfc-gh-aling
sfc-gh-aling reviewed Oct 7, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
@sfc-gh-aherreraaguilar
Merge branch 'refs/heads/main' into feature/aherrera/SNOW-2380327-Geo…
78371c3 
…spatialPart6

# Conflicts:
#	CHANGELOG.md
@sfc-gh-aherreraaguilar
Merge branch 'refs/heads/main' into feature/aherrera/SNOW-2380327-Geo…
c440018 
…spatialPart6

# Conflicts:
#	CHANGELOG.md
#	docs/source/snowpark/functions.rst
#	src/snowflake/snowpark/_functions/scalar_functions.py
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar merged commit ec7b377 into main Oct 8, 2025
28 of 29 checks passed
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar deleted the feature/aherrera/SNOW-2380327-GeospatialPart6 branch October 8, 2025 19:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-mayliu sfc-gh-mayliu Awaiting requested review from sfc-gh-mayliu sfc-gh-mayliu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-aherreraaguilar @sfc-gh-aling @sfc-gh-mvegaalvarez @sfc-gh-jrose