Skip to content

SNOW-2203826: Loosen flattening rules for sort and filter#4026

Merged
sfc-gh-yixie merged 35 commits into
mainfrom
yixie-SNOW-2203826-flatten-filter-sort-new
Apr 18, 2026
Merged

SNOW-2203826: Loosen flattening rules for sort and filter#4026
sfc-gh-yixie merged 35 commits into
mainfrom
yixie-SNOW-2203826-flatten-filter-sort-new

Conversation

@sfc-gh-yixie

@sfc-gh-yixie sfc-gh-yixie commented Dec 9, 2025

Copy link
Copy Markdown
Collaborator

Some old commits in the main branch were changed so #3941 can't be merged. This PR is a recreation of #3941 with the same code change.

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2203826

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yixie sfc-gh-yixie requested review from a team as code owners December 9, 2025 19:40
@github-actions github-actions Bot added the local testing Local Testing issues/PRs label Dec 9, 2025
Comment thread src/snowflake/snowpark/session.py

@sfc-gh-pwojcik sfc-gh-pwojcik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some minor comments

Comment thread src/snowflake/snowpark/_internal/analyzer/select_statement.py Outdated
Comment thread src/snowflake/snowpark/_internal/analyzer/select_statement.py Outdated
Comment thread src/snowflake/snowpark/session.py Outdated
@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 3 committers have signed the CLA.
✅ (sfc-gh-yixie)[https://github.com/sfc-gh-yixie]
@sfc-gh-aling
@sfc-gh-mayliu
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Comment thread src/snowflake/snowpark/session.py Outdated
@codecov-commenter

codecov-commenter commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.17%. Comparing base (7c853e1) to head (9cde5a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ke/snowpark/_internal/analyzer/select_statement.py 98.24% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4026      +/-   ##
==========================================
- Coverage   95.42%   95.17%   -0.25%     
==========================================
  Files         171      171              
  Lines       43615    43683      +68     
  Branches     7459     7475      +16     
==========================================
- Hits        41620    41577      -43     
- Misses       1220     1288      +68     
- Partials      775      818      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-yixie sfc-gh-yixie added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Apr 17, 2026
@sfc-gh-yixie

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-yixie sfc-gh-yixie merged commit 07689e0 into main Apr 18, 2026
29 of 30 checks passed
@sfc-gh-yixie sfc-gh-yixie deleted the yixie-SNOW-2203826-flatten-filter-sort-new branch April 18, 2026 00:52
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

local testing Local Testing issues/PRs NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants