NO-SNOW: Add pyarrow to dev dependencies and fix no-pandas test failures#4181
Merged
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4181 +/- ##
==========================================
- Coverage 95.42% 95.17% -0.26%
==========================================
Files 171 171
Lines 43615 43615
Branches 7459 7459
==========================================
- Hits 41620 41510 -110
- Misses 1220 1288 +68
- Partials 775 817 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c1c5d7e to
4a1f33c
Compare
sfc-gh-aling
approved these changes
Apr 17, 2026
sfc-gh-helmeleegy
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Resolves a failure in the daily job for installations without the pandas extra: https://github.com/snowflakedb/snowpark-python/actions/runs/24500387346/job/71605865416
test_dataframe_reader_file.pyimports pyarrow directly, which is normally implicitly installed by installing pandas.test_query_generator.pyuses pandas to generate parquet files, and did not guard the import of the library.Skips a failing test in
TimeSeriesTesting.ipynbdue to a bug with modin on pandas 2.3.3: modin-project/modin#7697. Downgrading the pandas version for the test is not an option due to pandas-dev/pandas#65213, so I've elected to skip the test instead.