Skip to content

NO-SNOW: Add pyarrow to dev dependencies and fix no-pandas test failures#4181

Merged
sfc-gh-joshi merged 2 commits into
mainfrom
joshi/fix-no-modin-tests
Apr 17, 2026
Merged

NO-SNOW: Add pyarrow to dev dependencies and fix no-pandas test failures#4181
sfc-gh-joshi merged 2 commits into
mainfrom
joshi/fix-no-modin-tests

Conversation

@sfc-gh-joshi

@sfc-gh-joshi sfc-gh-joshi commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

Resolves a failure in the daily job for installations without the pandas extra: https://github.com/snowflakedb/snowpark-python/actions/runs/24500387346/job/71605865416

test_dataframe_reader_file.py imports pyarrow directly, which is normally implicitly installed by installing pandas.

test_query_generator.py uses pandas to generate parquet files, and did not guard the import of the library.

Skips a failing test in TimeSeriesTesting.ipynb due to a bug with modin on pandas 2.3.3: modin-project/modin#7697. Downgrading the pandas version for the test is not an option due to pandas-dev/pandas#65213, so I've elected to skip the test instead.

@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@codecov-commenter

codecov-commenter commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (7c853e1) to head (4a1f33c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4181      +/-   ##
==========================================
- Coverage   95.42%   95.17%   -0.26%     
==========================================
  Files         171      171              
  Lines       43615    43615              
  Branches     7459     7459              
==========================================
- Hits        41620    41510     -110     
- Misses       1220     1288      +68     
- Partials      775      817      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi/fix-no-modin-tests branch from c1c5d7e to 4a1f33c Compare April 16, 2026 22:41
@sfc-gh-joshi sfc-gh-joshi merged commit c5362e4 into main Apr 17, 2026
28 of 30 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi/fix-no-modin-tests branch April 17, 2026 18:29
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants