Skip to content

NO-SNOW: Add pyarrow to dev dependencies and fix no-pandas test failures #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-joshi merged 2 commits into from
Apr 17, 2026
Merged

NO-SNOW: Add pyarrow to dev dependencies and fix no-pandas test failures #4181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39b3938
fix pyarrow dev dependencies and add pandas guard
sfc-gh-joshi Apr 16, 2026
4a1f33c
skip timeseries test
sfc-gh-joshi Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"snowflake.core>=1.0.0, <2", # Catalog
"psutil", # testing for telemetry
"lxml", # used in XML reader unit tests
"pyarrow", # used in dataframe reader tests
]
MODIN_DEVELOPMENT_REQUIREMENTS = [
# Snowpark pandas 3rd party library testing. Cap the scipy version because
Expand Down
9 changes: 8 additions & 1 deletion tests/integ/compiler/test_query_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@
import os
import re

import pandas
try:
import pandas

is_pandas_available = True
except ImportError:
is_pandas_available = False

import pytest

import snowflake.snowpark._internal.analyzer.snowflake_plan as snowflake_plan
Expand Down Expand Up @@ -568,6 +574,7 @@ def test_select_alias_identity(session):
)


@pytest.mark.skipif(not is_pandas_available, reason="pandas is required")
def test_disambiguate_skips_quoted_alias(session):
# SNOW-3176017: This tests a previous regression in a SnowML pipeline where alias optimization
# incorrectly removed an alias from """col_0""" (triple-quoted in SQL) to "col_0" (single-quoted).
Expand Down
4 changes: 3 additions & 1 deletion tests/notebooks/modin/TimeSeriesTesting.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,9 @@
}
],
"source": [
"ts.resample(\"2h\").mean()"
"# Skipped due to modin bug with pandas 2.3.3: https://github.com/modin-project/modin/issues/7697",
"# Cannot install lower versions of pandas 2.3 due to https://github.com/pandas-dev/pandas/issues/65213",
"# ts.resample(\"2h\").mean()"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion tests/notebooks/test_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
numpy==1.23.5
numpy
pytest<8.0.0
nbmake
matplotlib
Expand Down
Loading