Skip to content

NO-SNOW: Skip missed failing FIPS test.#4203

Merged
sfc-gh-aalam merged 6 commits into
mainfrom
aalam-NO-SNOW-skip-failing-fips-test
Apr 28, 2026
Merged

NO-SNOW: Skip missed failing FIPS test.#4203
sfc-gh-aalam merged 6 commits into
mainfrom
aalam-NO-SNOW-skip-failing-fips-test

Conversation

@sfc-gh-aalam

@sfc-gh-aalam sfc-gh-aalam commented Apr 27, 2026

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

  • Skip the remaining fips test that is failing due to 1.50.0 not being available. Follow-up of Fix daily test failure #4198.
  • Removed deprecated model snowflake-arctic

@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@codecov-commenter

codecov-commenter commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.73%. Comparing base (7601197) to head (b641868).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4203      +/-   ##
==========================================
- Coverage   95.41%   93.73%   -1.68%     
==========================================
  Files         171      171              
  Lines       43801    43801              
  Branches     7505     7505              
==========================================
- Hits        41794    41059     -735     
- Misses       1227     1917     +690     
- Partials      780      825      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Apr 27, 2026
@sfc-gh-aalam

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review April 28, 2026 19:35
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners April 28, 2026 19:35
@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) April 28, 2026 20:40
@sfc-gh-aalam sfc-gh-aalam merged commit 160c418 into main Apr 28, 2026
29 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-NO-SNOW-skip-failing-fips-test branch April 28, 2026 22:22
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants