Skip to content

NOSNSOW: Fix test_select_star_after_cached_parent when CTE optimization is disabled#4227

Merged
sfc-gh-helmeleegy merged 1 commit into
mainfrom
helmeleegy-NOSNOW-fix_disable_cte_opt
May 19, 2026
Merged

NOSNSOW: Fix test_select_star_after_cached_parent when CTE optimization is disabled#4227
sfc-gh-helmeleegy merged 1 commit into
mainfrom
helmeleegy-NOSNOW-fix_disable_cte_opt

Conversation

@sfc-gh-helmeleegy

Copy link
Copy Markdown
Contributor
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Fix test_select_star_after_cached_parent when CTE optimization is disabled.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner May 15, 2026 23:33
@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 15, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (0537409) to head (3990062).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4227      +/-   ##
==========================================
- Coverage   95.27%   95.16%   -0.12%     
==========================================
  Files         171      171              
  Lines       44158    44158              
  Branches     7535     7535              
==========================================
- Hits        42071    42022      -49     
- Misses       1295     1312      +17     
- Partials      792      824      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 029656c into main May 19, 2026
36 of 38 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-NOSNOW-fix_disable_cte_opt branch May 19, 2026 21:33
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants