Skip to content

SNOW-3538315: add type annotations to DataFrame telemetry decorators #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gitovska wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-3538315: add type annotations to DataFrame telemetry decorators #4230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/snowflake/snowpark/_internal/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from enum import Enum, unique
from logging import getLogger
import time
from typing import Any, Dict, List, Optional
from typing import Any, Callable, Dict, List, Optional, TypeVar

from snowflake.connector import SnowflakeConnection
from snowflake.connector.telemetry import (
Expand Down Expand Up @@ -48,6 +48,8 @@

_logger = getLogger(__name__)

_FuncT = TypeVar("_FuncT", bound=Callable[..., Any])


@unique
class TelemetryField(Enum):
Expand Down Expand Up @@ -369,7 +371,7 @@ def wrap(*args, **kwargs):
return wrap


def df_api_usage(func):
def df_api_usage(func: _FuncT) -> _FuncT:
@functools.wraps(func)
def wrap(*args, **kwargs):
with ResourceUsageCollector() as resource_usage_collector:
Expand Down Expand Up @@ -404,7 +406,7 @@ def wrap(*args, **kwargs):
return wrap


def df_to_relational_group_df_api_usage(func):
def df_to_relational_group_df_api_usage(func: _FuncT) -> _FuncT:
@functools.wraps(func)
def wrap(*args, **kwargs):
with ResourceUsageCollector() as resource_usage_collector:
Expand All @@ -419,7 +421,7 @@ def wrap(*args, **kwargs):


# For relational-grouped dataframe
def relational_group_df_api_usage(func):
def relational_group_df_api_usage(func: _FuncT) -> _FuncT:
@functools.wraps(func)
def wrap(*args, **kwargs):
with ResourceUsageCollector() as resource_usage_collector:
Expand Down
Loading