SNOW-3485471: fix aliased dataframe referencing wrong column#4246
Merged
sfc-gh-aling merged 2 commits intoJun 1, 2026
Conversation
sfc-gh-aalam
approved these changes
May 29, 2026
sfc-gh-joshi
approved these changes
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 171 171
Lines 44241 44241
Branches 7556 7556
=======================================
Hits 42204 42204
Misses 1250 1250
Partials 787 787 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixed a bug where calling
DataFrame.alias()twice on the same DataFrame (e.g. for a self-join) caused both aliases to share the same internal column-mapping dictionary. This madecol("R", "col")resolve to the same column ascol("L", "col"), producing incorrect join conditions and filter expressions.Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.