feat: Iceberg WAP branch read via VERSION_REF time travel#4267
feat: Iceberg WAP branch read via VERSION_REF time travel#4267sfc-gh-igarish wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
==========================================
- Coverage 95.52% 95.52% -0.01%
==========================================
Files 171 171
Lines 44358 44396 +38
Branches 7577 7585 +8
==========================================
+ Hits 42375 42411 +36
- Misses 1221 1222 +1
- Partials 762 763 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
there are some failing tests, please fix them and also improve the test coverage. thanks! |
|
Looks like this is changing a public class, should we add changelog for it? |
|
Thanks — working on this. Current failures look tied to missing CHANGELOG / AST / thread-safety checklist items plus unit-test gaps around the new |
|
Yes — |
688463b to
b5cd211
Compare
|
Addressed in b5cd211 — added CHANGELOG entry, fixed/extended unit tests (VERSION_REF message alignment + version_ref/branch validation coverage), and updated the PR description with the thread-safety / AST checklist items. |
|
Added CHANGELOG entry under 1.53.0 New Features in b5cd211. |
Extend TimeTravelConfig with version_ref and branch parameters, map Spark Iceberg branch/tag reader options, and emit Snowflake AT(VERSION_REF => ...) for named-ref reads. Tags continue to work through version_tag but now use the unified VERSION_REF SQL form.
Add CHANGELOG entry, align unit tests with unified VERSION_REF SQL and validation messages, and extend coverage for version_ref/branch validation. Co-authored-by: Cursor <cursoragent@cursor.com>
This surface is consumed only from Snowpark Connect (SAS), not as a standalone public Snowpark Python feature, so it should not appear in the release notes. Co-authored-by: Cursor <cursoragent@cursor.com>
b5cd211 to
263b01d
Compare
Summary
version_refandbranchtoTimeTravelConfigfor Iceberg WAP branch readsbranch,tag, andversion_refreader optionsAT(VERSION_REF => '<name>')for tag/branch named-ref reads (unifies priorVERSION_TAGSQL)Test plan
TimeTravelConfigand_extract_time_travel_from_optionsWhich Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3674169
Fill out the following pre-review checklist:
Please describe how your code change solves the related issue.
Extends
TimeTravelConfigwithversion_refandbranch, maps Spark Iceberg reader options (branch,tag,version_ref, existing tag aliases), and emits SnowflakeAT (VERSION_REF => '<name>')for named-ref reads. Tag reads keep the same customer-facing behavior while using the unifiedVERSION_REFSQL form.