SNOW-3654850: escape identifier quotes in all dialect generate_select_query methods#4272
Merged
Merged
Conversation
sfc-gh-yuwang
approved these changes
Jul 1, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sfc-gh-joshi
approved these changes
Jul 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4272 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 171 171
Lines 44305 44322 +17
Branches 7565 7565
=======================================
+ Hits 42322 42339 +17
Misses 1221 1221
Partials 762 762 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identifier quotes were not consistently escaped when building
generate_select_querySQL across the data-source dialects, which could produce malformed SQL for identifiers containing quote characters. This escapes them consistently in the base dialect and all dialect subclasses (Databricks, MySQL, Oracle, PostgreSQL, SQL Server).Changes
base_dialectand each dialect'sgenerate_select_query.tests/unit/test_dialect_quoting.py) and per-dialect integ tests.