ci(ud): expand UD compatibility workflow scope + fix bugs + reproducible UD build#4275
Draft
sfc-gh-fpawlowski wants to merge 3 commits into
Draft
Conversation
…e UD build Improvements on top of ud-ci-workflow-auto-triggered-full: - Scope (WI-1): matrix groups unit-integ / scala / modin / datasource / doctest, each run against UD; at-risk groups use continue-on-error so every gap is visible in one run. (unit-integ already covers udf via `or udf`.) - Bug fixes (WI-2): correct doctest tox env name (py313, not py3.13); split scala by path (tests/integ/scala) instead of `-k scala` name filter, which dropped scala-dir tests from both groups. - Reproducible UD build (WI-3): build-ud job builds the UD wheel once from a pinned ref (hatch build), caches by resolved commit, uploads as artifact; test legs install it via the existing ud_connector_path swap (deps first, UD force-reinstalled last so it wins regardless of connector version range) — no per-leg Rust rebuild. - Triggers/artifacts (WI-4): workflow_dispatch + nightly schedule + concurrency; pull_request gated to the UD integration branches; upload JUnit XML and a failing-test-name list per group. - Honest counts for odbc-reports (WI-5): disable reruns via UD_RERUN_FLAGS and keep the pytest terminal summary line in the log (odbc-reports sums those across all group logs). tox.ini gains backward-compatible UD_RERUN_FLAGS and JUNIT_REPORT_DIR hooks (no-ops when unset). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the base-branch restriction so the UD compatibility workflow runs on every PR (jobs are continue-on-error, so they never block). Keep workflow_dispatch and nightly schedule; include the `labeled` PR type so adding a label also triggers. Fork PRs still lack secrets — will revisit with label-gating as UD nears green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ud-ci-workflow-auto-triggered-full #4275 +/- ##
======================================================================
- Coverage 95.52% 94.29% -1.23%
======================================================================
Files 171 171
Lines 44299 44299
Branches 7564 7564
======================================================================
- Hits 42316 41772 -544
- Misses 1221 1665 +444
- Partials 762 862 +100 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
snowflakedb/universal-driver is a PUBLIC mirror (and has snowpark-compatibility). Passing an empty SNOWFLAKE_GITHUB_TOKEN made actions/checkout set an invalid auth header, so GitHub 401'd and the clone failed with "could not read Username". Drop the token input so checkout uses the default GITHUB_TOKEN, which reads public repos. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental improvements on top of
ud-ci-workflow-auto-triggered-full(base branch, so the diff is scoped to just these changes).What changes
unit-integ/scala/modin/datasource/doctest, each run against UD. At-risk groups usecontinue-on-errorso every gap is visible in one run. (unit-integalready covers UDF via theor udfmarker.)py313, notpy3.13); splitscalaby path (tests/integ/scala) instead of the-k scalaname filter that dropped scala-dir tests from both groups.build-udbuilds the UD wheel once from a pinned ref (hatch build), caches by resolved commit, uploads as an artifact; test legs install it via the existingud_connector_pathswap (deps first, UD force-reinstalled last so it wins regardless of connector version range) — no per-leg Rust rebuild.workflow_dispatch+ nightlyschedule+concurrency;pull_requestgated to the UD integration branches; upload JUnit XML + a failing-test-name list per group.UD_RERUN_FLAGS, keep the pytest terminal summary line in the log (odbc-reports sums those across group logs).tox.inigains backward-compatibleUD_RERUN_FLAGSandJUNIT_REPORT_DIRhooks (no-ops when unset).Deferred per discussion
Differential legacy-vs-UD baseline, parsing JUnit into our own summary, known-divergence xfail list, and switching odbc-reports to consume artifacts.
To verify on first dispatch run
build-ud:hatch buildinuniversal-driver/pythonsucceeds with rustup-stable + aptprotobuf-compiler(may need a pinned/newer protoc).UD_REFstill defaults to the floatingsnowpark-compatibilitybranch — pin a SHA for cross-run reproducibility.modingroup: emptyRERUN_FLAGSdoesn't breakrun_snowparkpandasnotdoctest.sharg handling.datasourcecarved out ofunit-integ; confirm nothing else intests/integimports DB drivers at collection.Follow-up
Once green enough, categorize the most common UD-vs-legacy failure causes from the uploaded results (missing connector private symbols like
_describe_internal, Arrow/fetch_pandasmismatches, PUT/GET, etc.) as the backlog for fixing UD or Snowpark.🤖 Generated with Claude Code