This repository was archived by the owner on Aug 13, 2024. It is now read-only.
Update Gems#20
Open
Michal Wrobel (sparrovv) wants to merge 1 commit into
Open
Conversation
Michal Wrobel (sparrovv)
commented
Feb 19, 2018
Michal Wrobel (sparrovv)
commented
Contributor
- httparty
- rspec
- httparty - rspec
|
Michal Wrobel (@sparrovv) has signed the Software Grant and Corporate Contributor License Agreement |
Contributor
Author
|
Anton Parkhomenko (@chuwy) Are there any other changes required? |
Contributor
|
Michal Wrobel (@sparrovv) nope, scheduling this! Thank you so much. |
| } | ||
|
|
||
| s.add_runtime_dependency "httparty", "<= 0.14.0" | ||
| s.add_runtime_dependency "httparty", "~> 0.15.0" |
There was a problem hiding this comment.
This locks down the version too tightly.
Suggested change
| s.add_runtime_dependency "httparty", "~> 0.15.0" | |
| s.add_runtime_dependency "httparty", "~> 0.15" |
|
Any chance some of these changes can be merged. It's been a long time and we are supporting a forked version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.