Skip to content

improve: prepare fetch_posix.c for platforms that miss getaddrinfo() #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergio-nsk merged 2 commits into from
Apr 1, 2026
Merged

improve: prepare fetch_posix.c for platforms that miss getaddrinfo() #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed48f43
fix: socket close in `fetch_get()`, possible leak
sergio-nsk Mar 31, 2026
2940b23
improve: prepare fetch_posix.c for platforms that miss getaddrinfo()
sergio-nsk Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions fetch_posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,14 @@

// Fetch proxy auto configuration using HTTP only
char *fetch_get(const char *url, int32_t *error) {
const int32_t socktype = SOCK_STREAM;
const int32_t protocol = IPPROTO_TCP;

struct addrinfo hints = {0};
struct addrinfo *address_info = NULL;
SOCKET sfd = 0;
struct sockaddr *addr = NULL;
socklen_t addrlen = 0;
SOCKET sfd = -1;
char *body = NULL;
char *host = NULL;
int32_t err = 0;
Expand Down Expand Up @@ -72,8 +77,8 @@ char *fetch_get(const char *url, int32_t *error) {

// Attempt to resolve the host name
hints.ai_family = AF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_protocol = IPPROTO_TCP;
hints.ai_socktype = socktype;
hints.ai_protocol = protocol;

err = getaddrinfo(host, port, &hints, &address_info);
if (err != 0) {
Expand All @@ -82,16 +87,19 @@ char *fetch_get(const char *url, int32_t *error) {
goto download_cleanup;
}

addr = address_info->ai_addr;
addrlen = address_info->ai_addrlen;

// Create communication socket
sfd = socket(address_info->ai_family, address_info->ai_socktype, address_info->ai_protocol);
sfd = socket(addr->sa_family, socktype, protocol);
if ((int)sfd == -1) {
err = socketerr;
log_error("Unable to create socket (%" PRId32 ")", err);
goto download_cleanup;
}

// Connect to remote address
err = connect(sfd, address_info->ai_addr, (int)address_info->ai_addrlen);
err = connect(sfd, addr, addrlen);
if (err != 0) {
err = socketerr;
log_debug("Unable to connect to host %s (%" PRId32 ")", host, err);
Expand Down Expand Up @@ -182,7 +190,7 @@ char *fetch_get(const char *url, int32_t *error) {
download_cleanup:
if (address_info)
freeaddrinfo(address_info);
if (sfd)
if (sfd != -1)
closesocket(sfd);

free(host);
Expand Down
Loading