feat: auto-refresh open HTML settings page on configuration change [IDE-1954] (#430)

feat(settings): auto-refresh open HTML settings page on configuration change [IDE-1954]

When $/snyk.configuration arrives from the Language Server, the HTML
settings preference page now reloads its content if it is currently
open. The LS emits this notification on auth, org change, folder add,
and folder remove — all the triggers from IDE-1954.

Implementation mirrors the existing notifyAuthTokenChanged() pattern:
a static reloadIfOpen() method guards against null/disposed browser
(capturing instance to a local variable to avoid TOCTOU), then
delegates to the existing loadContent() which dispatches the fetch
and browser.setText() via asyncExec internally.

The LS-side SettingIsLspInitialized guard (snyk-ls PR #1345)
prevents refresh storms during startup.

Author: basti-snyk

.gitignore

@@ -215,3 +215,27 @@ tests.json
 .commit-reviewed
 .pr-review-*.md
 .verify-metrics-pending
+.verify-complete
+.verify-precommit-hash
+.verify-staged-hash
+.verify-agents
+.verify-counts
+.verify-staged-diff
+.verify-branch-diff
+.verify-pr-context
+.verify-oracle.json
+.verify-oracle.log
+.verify-oracle-scope.txt
+.verify-oracle.pid
+.verify-lang-skill
+.verify-chunk-diff
+.verify-triage.json
+.verify-source-map.json
+.verify-dedup-findings.json
+.verify-reranked.json
+.snyk-sca-output.json
+.snyk-sca-output.err
+.snyk-code-output.json
+.snyk-code-output.err
+.verification-result.*
+*_????????_??????_*.log

plugin/src/main/java/io/snyk/eclipse/plugin/preferences/HTMLSettingsPreferencePage.java

@@ -367,6 +367,14 @@ public void dispose() {
     super.dispose();
   }
 
+  public static void reloadIfOpen() {
+    HTMLSettingsPreferencePage page = instance;
+    if (page == null || page.browser == null || page.browser.isDisposed()) {
+      return;
+    }
+    page.loadContent();
+  }
+
   public static void notifyAuthTokenChanged(String token, String apiUrl) {
     if (instance != null && instance.browser != null && !instance.browser.isDisposed()) {
       Display.getDefault()

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java

@@ -434,6 +434,7 @@ public void snykConfiguration(LspConfigurationParam param) {
 					this.toolView.refreshDeltaReference();
 				}
 			}
+			HTMLSettingsPreferencePage.reloadIfOpen();
 		} catch (Exception e) {
 			SnykLogger.logError(e);
 		}

tests/src/test/java/io/snyk/eclipse/plugin/preferences/HTMLSettingsPreferencePageTest.java

@@ -325,6 +325,21 @@ void parseAndSaveConfig_mixedNullAndValueFields() throws Exception {
 		assertEquals("new-org", prefs.getPref(Preferences.ORGANIZATION_KEY));
 	}
 
+	@Test
+	void reloadIfOpen_noOpWhenPageNeverOpened() throws Exception {
+		// Force instance to null by disposing the page created in setUp()
+		page.dispose();
+		// Now instance == null; reloadIfOpen() must not throw
+		org.junit.jupiter.api.Assertions.assertDoesNotThrow(() -> HTMLSettingsPreferencePage.reloadIfOpen());
+	}
+
+	@Test
+	void reloadIfOpen_noOpWhenBrowserNotCreated() {
+		// page was created in setUp() but createContents() was never called,
+		// so browser is null — reloadIfOpen() must not throw
+		org.junit.jupiter.api.Assertions.assertDoesNotThrow(() -> HTMLSettingsPreferencePage.reloadIfOpen());
+	}
+
 	@Test
 	void parseAndSaveConfig_folderFieldSentAsNullBecomesReset() throws Exception {
 		FolderConfigSettings.setInstance(new FolderConfigSettings());

tests/src/test/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClientTest.java

@@ -30,6 +30,7 @@
 import org.mockito.Mockito;
 
 import io.snyk.eclipse.plugin.analytics.TaskProcessor;
+import io.snyk.eclipse.plugin.preferences.HTMLSettingsPreferencePage;
 import io.snyk.eclipse.plugin.preferences.Preferences;
 import io.snyk.eclipse.plugin.views.snyktoolview.ISnykToolView;
 import io.snyk.languageserver.LsBaseTest;
@@ -718,4 +719,39 @@ private static void setAuthCompleteFuture(SnykExtendedLanguageClient lc,
 		f.setAccessible(true);
 		((java.util.concurrent.atomic.AtomicReference<java.util.concurrent.CompletableFuture<Void>>) f.get(lc)).set(future);
 	}
+
+	@Test
+	void snykConfigurationReloadsOpenSettingsPage() {
+		var gson = new com.google.gson.Gson();
+		String json = """
+				{
+					"settings": {
+						"api_endpoint": {
+							"value": "https://reload-test.snyk.io"
+						}
+					}
+				}
+				""";
+		LspConfigurationParam param = gson.fromJson(json, LspConfigurationParam.class);
+
+		try (MockedStatic<HTMLSettingsPreferencePage> mockedPage = mockStatic(HTMLSettingsPreferencePage.class)) {
+			cut = new SnykExtendedLanguageClient();
+			cut.snykConfiguration(param);
+
+			mockedPage.verify(() -> HTMLSettingsPreferencePage.reloadIfOpen(), Mockito.times(1));
+		}
+	}
+
+	@Test
+	void snykConfigurationReloadsEvenWithEmptyPayload() {
+		var gson = new com.google.gson.Gson();
+		LspConfigurationParam param = gson.fromJson("{}", LspConfigurationParam.class);
+
+		try (MockedStatic<HTMLSettingsPreferencePage> mockedPage = mockStatic(HTMLSettingsPreferencePage.class)) {
+			cut = new SnykExtendedLanguageClient();
+			assertDoesNotThrow(() -> cut.snykConfiguration(param));
+
+			mockedPage.verify(() -> HTMLSettingsPreferencePage.reloadIfOpen(), Mockito.times(1));
+		}
+	}
 }