Merge pull request #6 from soburi/copilot/sub-pr-4-again

Add bounds checking for arduino_pins array access in digital_pin_gpios path

Author: soburi

.gitignore

@@ -1 +1,3 @@
 rust/Cargo.lock
+_codeql_build_dir/
+_codeql_detected_source_root

cores/arduino/zephyrCommon.cpp

@@ -115,22 +115,25 @@ constexpr inline pin_size_t global_gpio_pin(const struct device *lport, pin_size
 
 constexpr inline const struct device *local_gpio_port(pin_size_t gpin) {
 #if DT_NODE_HAS_PROP(DT_PATH(zephyr_user), digital_pin_gpios)
-  return arduino_pins[gpin].port;
+  return (gpin < ARRAY_SIZE(arduino_pins)) ? arduino_pins[gpin].port : nullptr;
 #else
   return local_gpio_port_r(gpin, gpio_ports, 0, gpio_ngpios, ARRAY_SIZE(gpio_ports));
 #endif
 }
 
 constexpr inline pin_size_t local_gpio_pin(pin_size_t gpin) {
 #if DT_NODE_HAS_PROP(DT_PATH(zephyr_user), digital_pin_gpios)
-  return arduino_pins[gpin].pin;
+  return (gpin < ARRAY_SIZE(arduino_pins)) ? arduino_pins[gpin].pin : pin_size_t(-1);
 #else
   return port_idx(gpin) == pin_size_t(-1) ? pin_size_t(-1) : gpin - end_accum(port_idx(gpin));
 #endif
 }
 
 inline int global_gpio_pin_configure(pin_size_t pinNumber, int flags) {
 #if DT_NODE_HAS_PROP(DT_PATH(zephyr_user), digital_pin_gpios)
+  if (pinNumber >= ARRAY_SIZE(arduino_pins)) {
+    return -1;
+  }
   return gpio_pin_configure_dt(&arduino_pins[pinNumber], flags);
 #else
   const struct device *port = local_gpio_port(pinNumber);