docs/core: align LED_BUILTIN precedence and fix DTS docs#19
Merged
soburi merged 2 commits intoFeb 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns ArduinoCore-Zephyr’s LED_BUILTIN derivation behavior with the documented precedence when /zephyr,user/digital-pin-gpios is not defined, and fixes minor DTS documentation issues that could confuse readers/tools.
Changes:
- Update
cores/arduino/Arduino.hso/zephyr,user/builtin-led-gpiosis considered before falling back to theled0alias whendigital_pin_gpiosis absent. - Fix DTS examples in docs by adding the missing root closing
};. - Simplify duplicated wording in the
arduino_adcnotes in the configuration reference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cores/arduino/Arduino.h | Restores documented LED_BUILTIN precedence (builtin-led-gpios before led0) in the non-digital-pin-gpios code path. |
| documentation/configuration-guide.md | Fixes DTS example structure by adding the missing closing }; for the root node. |
| documentation/configuration-reference.md | Fixes DTS example structure, and cleans up arduino_adc notes formatting/duplication. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…mentation-issues-uh1j8t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LED_BUILTINis derived when/zephyr,user/digital-pin-gpiosis not present, causing the documented precedence (variant.h>/zephyr,user/builtin-led-gpios>led0) to not be respected in practice.};that could confuse readers and tools.document/variants.mdis intentionally left unchanged.Description
cores/arduino/Arduino.hto consider/zephyr,user/builtin-led-gpiosbefore falling back to theled0alias whendigital_pin_gpiosis not defined, restoring the documented precedence forLED_BUILTIN.arduino_headerDTS examples by adding the missing root closing};indocumentation/configuration-guide.mdanddocumentation/configuration-reference.md.arduino_adcnotes indocumentation/configuration-reference.mdto improve readability.Testing
git diff --checkto ensure no whitespace or index issues, which completed without errors.builtin_led_gpioscheck is present and documented behavior is aligned.Codex Task